Skip to content

Conversation

@mandreko-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/VULN-285

📔 Objective

Implement Zizmor workflow scanner.
Perform cleanup of existing workflows to be in compliance with Zizmor and bwwl.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@mandreko-bitwarden mandreko-bitwarden requested a review from a team as a code owner September 10, 2025 14:52
@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.59%. Comparing base (d98ff64) to head (aeb4d8e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5857   +/-   ##
=======================================
  Coverage   84.58%   84.59%           
=======================================
  Files         722      722           
  Lines       54880    54880           
  Branches     7568     7568           
=======================================
+ Hits        46420    46425    +5     
+ Misses       5810     5805    -5     
  Partials     2650     2650           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 10, 2025

Logo
Checkmarx One – Scan Summary & Details885464dc-3bc6-4f59-9fc4-09b2eca3f26c

Great job! No new security vulnerabilities introduced in this pull request

@mandreko-bitwarden mandreko-bitwarden marked this pull request as draft September 10, 2025 15:41
@mandreko-bitwarden mandreko-bitwarden marked this pull request as ready for review October 7, 2025 18:43
@mandreko-bitwarden mandreko-bitwarden added this pull request to the merge queue Oct 9, 2025
Merged via the queue into main with commit 81fa635 Oct 9, 2025
9 checks passed
@mandreko-bitwarden mandreko-bitwarden deleted the vuln-285 branch October 9, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants