[PM-15553] Add remote flag to control cipher key encryption. #4457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrebispo5
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
| data object CipherKeyEncryption : FlagKey<Boolean>() { | ||
| override val keyName: String = "cipher-key-encryption" | ||
| override val defaultValue: Boolean = true | ||
| override val isRemotelyConfigured: Boolean = true |
There was a problem hiding this comment.
Should this be off right now, usually we do not turn this on until the feature is 100% ready?
There was a problem hiding this comment.
The feature was already active if server version was at least "2024.2.0".
| serverConfigRepository.serverConfigStateFlow.value, | ||
| CIPHER_KEY_ENC_MIN_SERVER_VERSION, | ||
| ), | ||
| getCipherKeyEncryptionFlagState(), |
There was a problem hiding this comment.
If the flag changes, this will not be applied until the app restarts. I assume we are OK with that.
There was a problem hiding this comment.
Yes it is acceptable in this case.
|
New Issues
Fixed Issues
|
david-livefront
approved these changes
Dec 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4457 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15553
📔 Objective
Pass down to the SDK a remote flag value to control the cipher key encryption feature state.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes