-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-15057] Add utility for loading FIDO2 icons #4371
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaintPatrck
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
November 22, 2024 20:54
New Issues
Fixed Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4371 +/- ##
=======================================
Coverage 89.01% 89.02%
=======================================
Files 451 452 +1
Lines 39123 39142 +19
Branches 5532 5533 +1
=======================================
+ Hits 34827 34846 +19
Misses 2368 2368
Partials 1928 1928 ☔ View full report in Codecov by Sentry. |
app/src/main/java/com/x8bit/bitwarden/ui/platform/util/IconCompatUtils.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/x8bit/bitwarden/ui/platform/util/IconCompatUtils.kt
Outdated
Show resolved
Hide resolved
Add a utility function to load FIDO2 icons from IconData or a default resource.
SaintPatrck
force-pushed
the
PM-15057/iconcompat-utils
branch
from
December 2, 2024 19:27
5c4b535
to
d6710ad
Compare
david-livefront
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-15057
📔 Objective
Add a utility function to load FIDO2 icons from IconData or a default resource. This will be used to provide web based icons for relying parties, when the corresponding setting is enabled.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes