Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log vault deserialization errors #4353

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

david-livefront
Copy link
Collaborator

🎟️ Tracking

N/A

📔 Objective

This PR adds non-fatal logging to deserialization errors that occur when pulling data from the vault database.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Logo
Checkmarx One – Scan Summary & Details7219aa9b-cf3c-4758-bb2c-47b4e866a1ea

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 875 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 26

@david-livefront david-livefront force-pushed the vault-deserialization-errors branch from 15b8016 to d5d3292 Compare November 21, 2024 17:20
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.00%. Comparing base (245fcd7) to head (d5d3292).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...bit/bitwarden/data/platform/util/JsonExtensions.kt 50.00% 2 Missing ⚠️
.../data/vault/datasource/disk/VaultDiskSourceImpl.kt 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4353      +/-   ##
==========================================
- Coverage   89.01%   89.00%   -0.01%     
==========================================
  Files         452      452              
  Lines       39140    39149       +9     
  Branches     5524     5524              
==========================================
+ Hits        34839    34846       +7     
- Misses       2375     2377       +2     
  Partials     1926     1926              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@david-livefront
Copy link
Collaborator Author

Thanks @dseverns-livefront

@david-livefront david-livefront added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 57ea58f Nov 21, 2024
9 checks passed
@david-livefront david-livefront deleted the vault-deserialization-errors branch November 21, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants