PM-15110: Ensure all network requests always use the current environment data #4344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-livefront
requested review from
brian-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
|
New Issues
Fixed Issues
|
david-livefront
force-pushed
the
PM-15110-frequent-logouts
branch
from
29660b6 to
ba4a316
Compare
| */ | ||
| class BaseUrlInterceptor : Interceptor { | ||
| class BaseUrlInterceptor( | ||
| private val baseUrlProvider: () -> String?, |
| import kotlinx.coroutines.flow.Flow | ||
| import kotlinx.coroutines.flow.onSubscription | ||
|
|
||
| class FakeEnvironmentDiskSource : EnvironmentDiskSource { |
dseverns-livefront
approved these changes
Nov 20, 2024
|
Thanks @dseverns-livefront |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4344 +/- ##
==========================================
- Coverage 88.99% 88.98% -0.01%
==========================================
Files 453 452 -1
Lines 39109 39088 -21
Branches 5513 5513
==========================================
- Hits 34805 34784 -21
Misses 2377 2377
Partials 1927 1927 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-15110
📔 Objective
This PR addresses a bug where a user not using the US environment (default) could make a request to refresh the token before before the coroutine flow would update the environment data. To fix this, the
BaseUrlInterceptorsnow use the environment retrieved synchronously from theEnvironmentDiskSource.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes