[PM-15050] Track vault registration for CXP export in settings #4335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaintPatrck
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
|
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4335 +/- ##
=======================================
Coverage 88.99% 88.99%
=======================================
Files 453 453
Lines 39097 39117 +20
Branches 5510 5512 +2
=======================================
+ Hits 34794 34812 +18
Misses 2377 2377
- Partials 1926 1928 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
app/src/test/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryTest.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceImpl.kt
Outdated
Show resolved
Hide resolved
Add a new setting to track whether or not a user has previously registered their vault for export via the credential exchange protocol.
…egistration-prefs
SaintPatrck
force-pushed
the
PM-15050/cxp-export-registration-prefs
branch
from
bc72465 to
6fce0b1
Compare
SaintPatrck
force-pushed
the
PM-15050/cxp-export-registration-prefs
branch
from
6fce0b1 to
3c22e2d
Compare
app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/SettingsDiskSourceImpl.kt
Show resolved
Hide resolved
| override fun getVaultRegisteredForExport(userId: String): Boolean = | ||
| vaultRegisteredForExport[userId] ?: false | ||
|
|
||
| override fun storeVaultRegisteredForExport(userId: String, registered: Boolean?) { |
There was a problem hiding this comment.
Missed the clearData on the fake
david-livefront
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-15050
📔 Objective
Add a new setting to track whether or not a user has previously registered their vault for export via the credential exchange protocol.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes