Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRE-438 - Update Crowdin workflow to use app token #4321

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

vgrassia
Copy link
Member

🎟️ Tracking

📔 Objective

This PR updates the Crowdin Sync workflow to create the PR using a temporary token generated by our BW-GHApp.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vgrassia vgrassia requested a review from a team as a code owner November 18, 2024 16:46
@vgrassia vgrassia self-assigned this Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.00%. Comparing base (3742940) to head (2693807).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4321   +/-   ##
=======================================
  Coverage   89.00%   89.00%           
=======================================
  Files         452      452           
  Lines       38982    38982           
  Branches     5484     5484           
=======================================
  Hits        34697    34697           
  Misses       2375     2375           
  Partials     1910     1910           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailseaebb31c-7ade-4c22-91b8-6059202d8f20

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 26

@vgrassia vgrassia added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 6a0a7d7 Nov 18, 2024
9 checks passed
@vgrassia vgrassia deleted the bre-438_update-crowdin-sync branch November 18, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants