[PM-14656] Add default value to BaseEnumeratedIntSerializer
#4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a default value to the BaseEnumeratedIntSerializer to handle unknown values during deserialization. This ensures that unknown values will be deserialized to the specified default value instead of throwing an exception.
SaintPatrck
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
| return values.first { it.serialNameAnnotation?.value == decodedValue } | ||
| return values.firstOrNull { it.serialNameAnnotation?.value == decodedValue } | ||
| ?: default | ||
| ?: throw IllegalArgumentException("Unknown value $decodedValue") |
david-livefront
approved these changes
Nov 8, 2024
|
No New Or Fixed Issues Found |
SaintPatrck
changed the title
BaseEnumeratedIntSerializerBaseEnumeratedIntSerializer
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4272 +/- ##
=======================================
Coverage 88.97% 88.97%
=======================================
Files 445 445
Lines 38882 38885 +3
Branches 5468 5468
=======================================
+ Hits 34596 34599 +3
Misses 2369 2369
Partials 1917 1917 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14656
📔 Objective
Adds a default value to the BaseEnumeratedIntSerializer to handle unknown values during deserialization. This ensures that unknown values will be deserialized to the specified default value instead of throwing an exception.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes