[PM-11303] Add button missing for folders #4250
Conversation
andrebispo5
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4250 +/- ##
=======================================
Coverage 89.05% 89.06%
=======================================
Files 445 445
Lines 38756 38766 +10
Branches 5418 5420 +2
=======================================
+ Hits 34515 34525 +10
Misses 2362 2362
Partials 1879 1879 ☔ View full report in Codecov by Sentry. |
| @@ -127,7 +127,7 @@ fun VaultAddEditState.ViewState.appendFolderAndOwnerData( | |||
| common = currentContentState.common.copy( | |||
| selectedFolderId = folderViewList.toSelectedFolderId( | |||
| cipherView = currentContentState.common.originalCipher, | |||
| ), | |||
| ) ?: currentContentState.common.selectedFolderId, | |||
There was a problem hiding this comment.
Can you move this down a line to match the chaining pattern:
)
?: currentContentState.common.selectedFolderId,| onNavigateToVaultAddItemScreen: ( | ||
| cipherType: VaultItemCipherType, | ||
| selectedFolderId: String?, | ||
| ) -> Unit, |
There was a problem hiding this comment.
Can you apply the formatter here
| @@ -2089,7 +2096,7 @@ data class VaultItemListingState( | |||
| get() = folderId | |||
| ?.let { folderName.asText() } | |||
| ?: R.string.folder_none.asText() | |||
| override val hasFab: Boolean get() = false | |||
| override val hasFab: Boolean get() = true | |||
| onNavigateToVaultAddItemScreen: ( | ||
| vaultItemCipherType: VaultItemCipherType, | ||
| selectedFolderId: String?, | ||
| ) -> Unit, |
| @@ -942,6 +942,26 @@ class VaultItemListingViewModelTest : BaseViewModelTest() { | |||
| } | |||
| } | |||
|
|
|||
| @Suppress("MaxLineLength") | |||
| @Test | |||
| fun `AddVaultItemClick inside a folder should emit NavigateToAddVaultItem with a selected folder id`() = runTest { | |||
There was a problem hiding this comment.
Formatter, there are instructions on how to setup the macro for this here
There was a problem hiding this comment.
Sorry I had it configured already I just forgot about it thinking that the gradle detekt would apply our code styling as well.
| @@ -117,7 +117,9 @@ class VaultItemListingScreenTest : BaseComposeTest() { | |||
| biometricsManager = biometricsManager, | |||
| onNavigateBack = { onNavigateBackCalled = true }, | |||
| onNavigateToVaultItem = { onNavigateToVaultItemId = it }, | |||
| onNavigateToVaultAddItemScreen = { onNavigateToVaultAddItemScreenCalled = true }, | |||
| onNavigateToVaultAddItemScreen = { _, _ -> | |||
| onNavigateToVaultAddItemScreenCalled = true | |||
There was a problem hiding this comment.
Is there a reason to change this?
There was a problem hiding this comment.
otherwise it won't even compile.
There was a problem hiding this comment.
Ahh, I see the underscores now. 😄
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11303
📔 Objective
📸 Screenshots
Screen.Recording.2024-11-06.at.22.04.20.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes