-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-14526] Add JsonNames annotation to SyncResponseJson #4247
Merged
SaintPatrck
merged 1 commit into
release/hotfix-v2024.11.1
from
hotfix-v2024.11.1/profile-and-domain-alt-json-names
Nov 6, 2024
Merged
[PM-14526] Add JsonNames annotation to SyncResponseJson #4247
SaintPatrck
merged 1 commit into
release/hotfix-v2024.11.1
from
hotfix-v2024.11.1/profile-and-domain-alt-json-names
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `@JsonNames` annotation to the `profile` and `domains` properties in the `SyncResponseJson` data class. This ensures that the properties are correctly deserialized even if the server response uses different casing for the property names.
SaintPatrck
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
November 6, 2024 20:07
vvolkgang
approved these changes
Nov 6, 2024
New Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/hotfix-v2024.11.1 #4247 +/- ##
============================================================
Coverage ? 88.94%
============================================================
Files ? 439
Lines ? 38052
Branches ? 5336
============================================================
Hits ? 33845
Misses ? 2345
Partials ? 1862 ☔ View full report in Codecov by Sentry. |
SaintPatrck
deleted the
hotfix-v2024.11.1/profile-and-domain-alt-json-names
branch
November 6, 2024 20:38
SaintPatrck
added a commit
that referenced
this pull request
Nov 8, 2024
SaintPatrck
pushed a commit
that referenced
this pull request
Nov 8, 2024
SaintPatrck
pushed a commit
that referenced
this pull request
Nov 8, 2024
SaintPatrck
pushed a commit
that referenced
this pull request
Nov 8, 2024
SaintPatrck
pushed a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14526
📔 Objective
Adds the
@JsonNames
annotation to theprofile
anddomains
properties in theSyncResponseJson
data class.This ensures that the properties are correctly deserialized even if the server response uses different casing for the property names.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes