Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-14353 : Clean up consumed snackbar on quick resubmission due to state based nav. #4235

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

dseverns-livefront
Copy link
Collaborator

@dseverns-livefront dseverns-livefront commented Nov 5, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14353

📔 Objective

  • Snackbar was briefly showing while the account was switched, due to the navigation being user state based the next instance of the VaultViewModel was collecting from the shared flow before it was removed from the internal map on completion of the previous instance.
  • Added a function to explicitly clear the replay cache.

📸 Screenshots

before after
example pm14353after.webm

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.05%. Comparing base (8f9585e) to head (b917272).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4235   +/-   ##
=======================================
  Coverage   89.05%   89.05%           
=======================================
  Files         445      445           
  Lines       38700    38704    +4     
  Branches     5412     5413    +1     
=======================================
+ Hits        34464    34468    +4     
  Misses       2359     2359           
  Partials     1877     1877           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dseverns-livefront dseverns-livefront added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit e397c03 Nov 6, 2024
9 checks passed
@dseverns-livefront dseverns-livefront deleted the PM-14353-snackbar-after-switch branch November 6, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants