Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14254] Keep Android verifier for JNI usage #4197

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

SaintPatrck
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14254

📔 Objective

The Android Verifier component is incorrectly flagged as dead code by Proguard, as it's unable to detect JNI usage.
This change manually keeps the org.rustls.platformverifier classes to resolve the issue.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

The Android Verifier component is incorrectly flagged as dead code by Proguard, as it's unable to detect JNI usage.
This change manually keeps the `org.rustls.platformverifier` classes to resolve the issue.
@SaintPatrck SaintPatrck changed the title [PM-14254] Keep Android platform verifier for JNI usage [PM-14254] Keep Android verifier for JNI usage Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.09%. Comparing base (0211729) to head (4f6121c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4197   +/-   ##
=======================================
  Coverage   89.09%   89.09%           
=======================================
  Files         445      445           
  Lines       38640    38640           
  Branches     5406     5406           
=======================================
  Hits        34425    34425           
  Misses       2343     2343           
  Partials     1872     1872           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SaintPatrck SaintPatrck added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit fab0187 Oct 30, 2024
9 checks passed
@SaintPatrck SaintPatrck deleted the PM-14254/keep-rust-cert-verifier branch October 30, 2024 14:58
SaintPatrck added a commit that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants