Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-14009 Refactor storing first time values to the first time action manager #4161

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

dseverns-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14009

📔 Objective

  • Centralize observation and modifying "FirstTimeState" values to all be contained within the FirstTimeActionManager
  • This change will support work towards changing behavior with interaction with the action cards for import logins as well as adjusting when the cards are dismissed for the settings.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details2c66b5ce-42cf-4f06-9984-46b64f0bc150

No New Or Fixed Issues Found

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.94%. Comparing base (0ff2fe6) to head (db7078d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ata/platform/manager/FirstTimeActionManagerImpl.kt 75.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4161      +/-   ##
==========================================
- Coverage   88.95%   88.94%   -0.01%     
==========================================
  Files         439      439              
  Lines       38077    38075       -2     
  Branches     5336     5334       -2     
==========================================
- Hits        33871    33867       -4     
  Misses       2346     2346              
- Partials     1860     1862       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dseverns-livefront dseverns-livefront added this pull request to the merge queue Oct 25, 2024
@dseverns-livefront
Copy link
Collaborator Author

Danke @david-livefront !

Merged via the queue into main with commit eb4ffeb Oct 25, 2024
9 checks passed
@dseverns-livefront dseverns-livefront deleted the refactor-firsttime-settings-storage branch October 25, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants