QA-953: Adding testTag to elements in Add TOTP screen #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifernandezdiaz
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4160 +/- ##
=======================================
Coverage 88.95% 88.95%
=======================================
Files 439 439
Lines 38080 38086 +6
Branches 5336 5336
=======================================
+ Hits 33874 33880 +6
Misses 2346 2346
Partials 1860 1860 ☔ View full report in Codecov by Sentry. |
| @@ -126,7 +127,8 @@ fun ManualCodeEntryScreen( | |||
| Text( | |||
| text = stringResource(id = R.string.enter_key_manually), | |||
| style = BitwardenTheme.typography.titleMedium, | |||
| modifier = Modifier.padding(horizontal = 16.dp), | |||
| modifier = Modifier.padding(horizontal = 16.dp) | |||
| .testTag("EnterKeyManuallyButton"), | |||
There was a problem hiding this comment.
Please run the formatter
There was a problem hiding this comment.
This is still incorrect, it should be:
modifier = Modifier
.padding(horizontal = 16.dp)
.testTag("EnterKeyManuallyButton"),There is also a tutorial for setting up a macro for this in the readme.
There was a problem hiding this comment.
My bad! I applied the formatter but I forgot to configure it with our current code style
SaintPatrck
previously approved these changes
Oct 25, 2024
david-livefront
requested changes
Oct 25, 2024
david-livefront
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
This work is a subtask of QA-947, a story created to group all the native app views that contain elements without Automation IDs.
NOTE: Not all the elements will require an AutomationID. We are adding the ones we currently need so we can reduce the flakiness on some critical Mobile e2e tests
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes