Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13789] add credential manager provider for passwords #4110

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
fc882d2
add BitwardenPasswordProviderService as CredentialProviderService for…
Nailik Oct 17, 2024
1f301f2
add intents for PasswordProviderProcessor
Nailik Oct 17, 2024
ab9161c
initial test to provide Password Credential Entry
Nailik Oct 17, 2024
ab361c9
PasswordIntentUtils according to Fido2IntentUtils
Nailik Oct 19, 2024
c3473b9
add SpecialCircumstance to handle PasswordCredential intents
Nailik Oct 19, 2024
cab85a9
add RootNavState for PasswordCredential
Nailik Oct 19, 2024
c74bc86
finish Save PasswordCredential via Credential Manager Api
Nailik Oct 19, 2024
5a6e528
GetPasswordCredentialRequest handling
Nailik Oct 20, 2024
b30ebd9
empty username/password instead of error on credential selection
Nailik Oct 20, 2024
94cd7af
renamed BitwardenFido2ProviderService.kt to BitwardenCredentialProvid…
Nailik Oct 20, 2024
1ec7bdd
combined fido2 and password credential provider into BitwardenCredent…
Nailik Oct 20, 2024
c0190c0
Revert "combined fido2 and password credential provider into Bitwarde…
Nailik Oct 20, 2024
9d422e2
remove unused
Nailik Oct 20, 2024
9398697
Revert "Revert "combined fido2 and password credential provider into …
Nailik Oct 20, 2024
07949fd
combine provider service
Nailik Oct 20, 2024
040e4f3
password assertion
Nailik Oct 20, 2024
52f02d1
rework Fido2CompletionManager.kt to CredentialCompletionManager to su…
Nailik Oct 20, 2024
0a838fa
WIP improve saving password credentials
Nailik Oct 20, 2024
12b37c5
WIP overwriting already present username/password combinations (dialogs)
Nailik Oct 20, 2024
bf7a725
dialogs
Nailik Oct 21, 2024
9d5e340
overwrite confirmation dialog state text
Nailik Oct 21, 2024
d13a582
removed unused import
Nailik Oct 21, 2024
6eb6907
reuse open bitwarden action
Nailik Oct 21, 2024
e9aae37
handle password error in unlock screen
Nailik Oct 21, 2024
38465ed
clean up
Nailik Oct 21, 2024
b344e71
fix manifest
Nailik Oct 21, 2024
4c7f7ae
comments
Nailik Oct 21, 2024
518d60a
reformat code
Nailik Oct 21, 2024
1dd1c4e
Merge branch 'main' into feature/add-password-credential-manager-prov…
Nailik Oct 22, 2024
3525469
Merge branch 'main' into feature/add-password-credential-manager-prov…
Nailik Nov 1, 2024
8538e57
Merge branch 'bitwarden:main' into feature/add-password-credential-ma…
Nailik Nov 6, 2024
77f9f40
Merge branch 'main' into feature/add-password-credential-manager-prov…
Nailik Nov 19, 2024
ebf448d
Merge branch 'main' into feature/add-password-credential-manager-prov…
Nailik Nov 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into feature/add-password-credential-manager-prov…
…ider

# Conflicts:
#	app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt
  • Loading branch information
Nailik committed Nov 1, 2024
commit 3525469474aaafeb9eae103bc90410b63f964352
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import com.x8bit.bitwarden.data.autofill.util.isActiveWithFido2Credentials
import com.x8bit.bitwarden.data.autofill.util.isActiveWithPasswordCredentials
import com.x8bit.bitwarden.data.autofill.util.isActiveWithUsernameAndPasswordCredentials
import com.x8bit.bitwarden.data.autofill.util.isActiveWithUsernameCredentials
import com.x8bit.bitwarden.data.platform.manager.FeatureFlagManager
import com.x8bit.bitwarden.data.platform.manager.PolicyManager
import com.x8bit.bitwarden.data.platform.manager.SpecialCircumstanceManager
import com.x8bit.bitwarden.data.platform.manager.clipboard.BitwardenClipboardManager
Expand Down Expand Up @@ -135,8 +136,7 @@ class VaultAddEditViewModel @Inject constructor(
// Exit on save if handling an autofill, Fido2 Attestation, Password creation, or TOTP link
val shouldExitOnSave = autofillSaveItem != null ||
fido2AttestationOptions != null ||
passwordCreationRequest != null ||
totpData != null
passwordCreationRequest != null

val dialogState = if (!settingsRepository.initialAutofillDialogShown &&
vaultAddEditType is VaultAddEditType.AddItem &&
Expand Down Expand Up @@ -1530,6 +1530,10 @@ class VaultAddEditViewModel @Inject constructor(
handleValidateFido2PinResultReceive(action)
}

is VaultAddEditAction.Internal.SshKeyCipherItemsFeatureFlagReceive -> {
handleSshKeyCipherItemsFeatureFlagReceive(action)
}

is VaultAddEditAction.Internal.PasswordRegisterCredentialResultReceive -> {
handlePasswordRegisterCredentialResultReceive(action)
}
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.