Skip to content

[PM-5907] Fix for incorrect TOTP white text color on label when using light theme on iOS #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dinisvieira merged 2 commits into from
Feb 7, 2024
Merged

[PM-5907] Fix for incorrect TOTP white text color on label when using light theme on iOS #2982

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d78f49
PM-5907 workaround for incorrect textcolor when programmatically chan…
dinisvieira Feb 6, 2024
7db3bf6
Update src/Core/Pages/Vault/CipherAddEditPage.xaml.cs
dinisvieira Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Core/Pages/Vault/CipherAddEditPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,14 @@ private async void ScanTotp_Clicked(object sender, System.EventArgs e)
{
await Navigation.PopModalAsync();
await _vm.UpdateTotpKeyAsync(key);

#if IOS
// HACK: To avoid a bug that incorrectly sets the TextColor when changing text
// programatically we need to set it to null and back to the correct color
// MAUI issue https://github.com/dotnet/maui/pull/20100
_loginTotpEntry.TextColor = null;
_loginTotpEntry.TextColor = ThemeManager.GetResourceColor("TextColor");
#endif
}
catch (Exception ex)
{
Expand Down