Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update XF and revert old workarounds #1885

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Update XF and revert old workarounds #1885

merged 1 commit into from
Apr 22, 2022

Conversation

mpbw2
Copy link
Contributor

@mpbw2 mpbw2 commented Apr 21, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

A fix for a long standing bug (that actually goes back further) in Xamarin.Forms was recently released, allowing us to roll back some yucky, icky workarounds.

Also added exception logging for diagnosing biometric issues, and removed unnecessary debug logging during state migration.

Code changes

  • .csproj files: Update Xamarin.Forms, Xamarin.CommunityToolkit, and Xamarin.Essentials
  • AddEditPage.*: Revert workaround
  • SendAddEditPage.*: Revert workaround
  • BiometricService.cs: Added exception logging
  • StateMigrationService.cs: Removed old debug logging

Testing requirements

As this required an update to Xamarin.Forms, full regression testing is advised.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@mpbw2 mpbw2 requested review from vvolkgang and a team April 21, 2022 22:47
vvolkgang
vvolkgang approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@vvolkgang vvolkgang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpbw2 mpbw2 merged commit ab6dde4 into master Apr 22, 2022
@mpbw2 mpbw2 deleted the bugfix-forms branch April 22, 2022 01:29
mpbw2 added a commit that referenced this pull request Apr 22, 2022
@mpbw2
update XF and revert old workarounds (#1885)
ac7a680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvolkgang vvolkgang vvolkgang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpbw2 @vvolkgang