Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to using shared workflow #1787

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Move to using shared workflow #1787

merged 1 commit into from
Feb 18, 2022

Conversation

mimartin12
Copy link

@mimartin12 mimartin12 commented Feb 18, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Updates to the linting workflows to reuse the workflow from our Github Actions repo.

Code changes

  • .github/workflows/workflow-linter.yml: Moved to using call-workflow to call the workflow from the GHA repository.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@mimartin12 mimartin12 marked this pull request as ready for review February 18, 2022 14:36
@mimartin12 mimartin12 requested a review from a team February 18, 2022 14:36
@mimartin12 mimartin12 self-assigned this Feb 18, 2022
@mimartin12 mimartin12 merged commit dd2c24d into master Feb 18, 2022
@mimartin12 mimartin12 deleted the update-shared-workflow branch February 18, 2022 19:29
fedemkr added a commit that referenced this pull request Feb 25, 2022
* master: (82 commits)
  Autosync the updated translations (#1812)
  Apply Disable Favicon setting globally to match desktop (#1811)
  Fix for missing bio unlock on app restart (#1810)
  Changed link on Settings "Change Master Password" and "Two Step Login" to go to the web vault settings. Also refactored a bit to reuse the urls (#1809)
  take environment into account when checking for existing account (#1808)
  Account Switching (#1807)
  Fixes incorrect path in workflow (#1806)
  [BEEEP] - Added workflows to ignored paths (#1802)
  Add dry run option to release workflow (#1801)
  Changed Input keyboard on phone to be the telephone keyboard and also capitalized the keyboard on some fields of add/edit identity (#1800)
  Fix Options being seen in two lines on Add/edit Send (#1798)
  Fix icon image size to be adaptive on Large Font Size Accessibility which fixes row height on large vault (#1795)
  We're Hiring (#1797)
  Moved to new Google Service Account (#1789)
  Moved to new Google Service Account (#1788)
  Move to using shared workflow (#1787)
  Autosync the updated translations (#1786)
  Fixed some Large Font Accessibility issues on Vault and Send screens for Icons Display #1774 (#1785)
  Created initial workflow for workflow linting (#1783)
  Enforce Hold label (#1779)
  ...

# Conflicts:
#	src/App/Pages/Accounts/DeleteAccountViewModel.cs
#	src/App/Pages/Settings/ExportVaultPageViewModel.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants