Update XF to remove AndroidX dependency hack #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscharf
reviewed
Sep 22, 2021
| @@ -49,7 +49,7 @@ private BottomNavigationView GetBottomNavigationView() | |||
| return null; | |||
| } | |||
|
|
|||
| async void BottomNavigationView.IOnNavigationItemReselectedListener.OnNavigationItemReselected(IMenuItem item) | |||
| public async void OnNavigationItemReselected(IMenuItem item) | |||
There was a problem hiding this comment.
Should this be async void or async Task? Feels like we need async Task to avoid latent exceptions or app crashes that aren't handled through this async call.
There was a problem hiding this comment.
Looks like we don't have a choice...
There was a problem hiding this comment.
Bummer, I didn't realize it was an interface method implementation. With async void you'll need to ensure that there's proper error handling/try-catch blocks to ensure exceptions are bubbled up outside of latent execution where we'd lose the stack-trace, etc.
cscharf
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SR5 release of Xamarin Forms (5.0.0.2125) fixed the broken AndroidX & Material dependencies of the previous release, allowing us to remove the extra dependencies added in #1471 and update others to the latest without breaking the build. This will close this Asana task.
(Note this does not yet fix this Asana task which we worked around in #1447 and #1454)
Also updated LiteDB, AppCenter, and .NET Test SDK to the latest.