Redefine cipher "share" to "move to organization" #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpbw2
reviewed
Jun 17, 2021
| @@ -1390,11 +1397,14 @@ | |||
| <data name="ShareItem" xml:space="preserve"> | |||
| <value>Share Item</value> | |||
| </data> | |||
| <data name="MoveToOrganization" xml:space="preserve"> | |||
| <value>Move to Organization</value> | |||
There was a problem hiding this comment.
This title is really snug in a few of those iOS screenshots, and will probably exceed the available width in some translated versions. That being said, I can't come up with a shorter way to convey 'move to organization' unless we start using 'Org' everywhere which isn't great. Any thoughts?
There was a problem hiding this comment.
The other verb I pitched was Transfer. This might be a good reason to use it.
That being said. These images were taken using an ipod touch. Even on the 8, there's quite a bit more room:
MGibson1
added a commit
that referenced
this pull request
Jun 24, 2021
MGibson1
added a commit
that referenced
this pull request
Aug 4, 2021
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The term "Share" is confusing to users because it implies maintaining ownership and control of a cipher while allowing others to access it as well. It also implies the ability to revoke access or to stop sharing -- neither of these things is true.
In addition to the share term being misleading, the
fa-share-alticon implies a forking of the cipher item rather than transferring ownership.When a cipher is "shared" it is irrevocably taken over by an organization. This occurs for good cryptographic and security reasons. The better solution to this is to revise the communication around "sharing." To that end, this work changes the term "share" to "move to organization" and the icon is changed to
fa-cube, which is used to indicate a collection. The act of moving an item to an organization is denoted byfa-arrow-circle-o-rightrather thanfa-share-alt.Screen shots
Item View Options
Item Edit Options
Move To Organization View
Move To Organization Toast
Item hint part of Organization