Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS Accessibility] Bugfix: VoiceOver always seeing fields for all entry types #1213

Closed
wants to merge 4 commits into from
Closed

[iOS Accessibility] Bugfix: VoiceOver always seeing fields for all entry types #1213

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5597a34
make VoiceOver only read password when visible
eliykat Jan 7, 2021
1c2c525
add/remove elements instead of using isVisible
eliykat Jan 11, 2021
e128611
Set IsInAccessibleTree prop to match IsVisible
eliykat Jan 11, 2021
1880e9b
Remove unnecessary AutomationProperties
eliykat Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove unnecessary AutomationProperties
  • Loading branch information
@eliykat
eliykat committed Jan 11, 2021
commit 1880e9bbb6a9efb3a7e707883277e5441cc4ecdf
14 changes: 5 additions & 9 deletions src/App/Pages/Vault/AddEditPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,15 +488,13 @@
Text="{u:I18n URI}"
StyleClass="box-label"
Grid.Row="0"
Grid.Column="0"
AutomationProperties.IsInAccessibleTree="{Binding BindingContext.IsLogin, Source={x:Reference _page}}" />
Grid.Column="0" />
<Entry
Text="{Binding Uri}"
Keyboard="Url"
StyleClass="box-value"
Grid.Row="1"
Grid.Column="0"
AutomationProperties.IsInAccessibleTree="{Binding BindingContext.IsLogin, Source={x:Reference _page}}" />
Grid.Column="0" />
<controls:FaButton
StyleClass="box-row-button, box-row-button-platform"
Text="&#xf013;"
Expand All @@ -505,7 +503,7 @@
Grid.Row="0"
Grid.Column="1"
Grid.RowSpan="2"
AutomationProperties.IsInAccessibleTree="{Binding BindingContext.IsLogin, Source={x:Reference _page}}"
AutomationProperties.IsInAccessibleTree="True"
AutomationProperties.Name="{u:I18n Options}" />
</Grid>
</DataTemplate>
Expand Down Expand Up @@ -696,13 +694,11 @@
<Label
Text="{Binding Collection.Name}"
StyleClass="box-label, box-label-regular"
HorizontalOptions="StartAndExpand"
AutomationProperties.IsInAccessibleTree="{Binding BindingContext.HasCollections,Source={x:Reference _page}}" />
HorizontalOptions="StartAndExpand" />
<Switch
IsToggled="{Binding Checked}"
StyleClass="box-value"
HorizontalOptions="End"
AutomationProperties.IsInAccessibleTree="{Binding BindingContext.HasCollections,Source={x:Reference _page}}" />
HorizontalOptions="End" />
</StackLayout>
<BoxView StyleClass="box-row-separator" />
</StackLayout>
Expand Down