-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android app crash when scanning TOTP QR Code #1228
Comments
Hi, I am the one who reported the bug via email to support@bitwarden.com, and Sugianto kindly logged this issue for me. Happy to provide more info as needed. |
Hi @juristat; I would like effectively more info since it also happen on my new phone and I had previously opened an issue for the same kind of behavior. My new phone is an Samsung Galaxy S8 (SM-G950F) "dreamlte" with Android Pie (9) I have the same issue with the Bitwarden app version 2.6.1. Previously I opened this issue but it was for a different phone. |
The same happens on a Samsung Galaxy J4 (2018). The camera viewfinder is somewhat narrower and the app crashes when it sees the QR code. |
Similar reports from bitwarden/mobile#1289:
|
I have the same issue. It seems to only happen on 'complex' QR codes. My workaround is to use Google Lens to get the URL from the QR, and paste the URL in Bitwarden. |
It appears that I've got the same issue: Device: Galaxy XCover 5 - SM-G525F/DS |
I've never found one that cant be scanned in my case it just takes multiple attempts. Device: Google Pixel 3 |
Same issue for me: Device: Samsung A50 |
I have never been able to scan a QR code from within the bitwarden app, it crashes on both official and custom roms (Android 7/8/9/10 all basd on Samsung oneui on my Galaxy S7 G930-F. The only time I did got it to work was when I used an AOSP based rom ( Android 9). I just use a seperate QR code scanning app and copy / paste the url into the Bitwarden apps TOTP field to get it it to work. |
Pixel 5. Crashes on Facebook TOTP setup; works fine on AWS Virtual MFA setup. |
Same issue: |
Crashes on any QR code scanning, wasn't able to make it work on Pixel 4a | Android 11 | Bitwarden 2.12.0 |
Same here. Android 11 (Lineage OS 18.1) |
Same here. |
+1, only occasionally crashes for me. |
+1 |
+1, ocasional crashes. Device: Asus Zenphone 3 Zoom (ZE553KL) I've tried to better understand what causes this, to make adding 2FA less of a hassle and hopefully help whoever looks into this in the future. But even testing different methods in different circumstances many times didn't lead me to any clear conclusion. A previous version of this comment said it did, which recently proved false upon further testing. I apologize for that, this is confusing. |
Thanks everyone for the info! We weren't able to replicate this in multiple devices but we suspect the linked PR changes will fix it. If you previously had this issue, can you download the .apk from our CI and test it please? Obligatory disclaimer: This isn't an official release that went through regression testing, there might be other unrelated issues overall, we just want to be sure this TOTP crash is fixed. Issue was automatically closed due to being linked in the PR but I'm reopening this until we figure it out. Edit: Updated the CI link |
* master: (34 commits) check email for null before authenticating (#1769) remove datepicker style workaround (#1768) Bump version to 2.16.2 (#1765) Improved code for periodic Autofocus on scan for better cancellation and task handlilng (#1764) Updated Sed expression for Android manifests (#1763) Bumped version to 2.16.1 (#1762) Add iOS Share Extension to our version bump automation (#1761) Bumped version to 2.16.0 (#1760) Improved Autofocus code on ScanPage for better cancellation and exception handling #1228 (#1759) [Help] Update links to new pattern (#1758) Client & Version headers (#1757) Autosync the updated translations (#1752) Fix delete account SSO with CME that the OTP parameter was being sent incorrectly to the server (#1751) [Icons] Fast follower changes (#1750) Removed punctuation on some string resources regarding send (#1747) Set background of biometricCell from theme (#1744) Cleared About information about push registration, just left it in DEBUG mode (#1742) Cleared Console.WriteLine for iOS push notifications issue (#1739) Autosync the updated translations (#1734) Update FA icons on LockPasswordViewController (#1729) ...
* master: [Icons] - BUG - Update groupings icon for collections (#1773) Autosync the updated translations (#1766) check email for null before authenticating (#1769) remove datepicker style workaround (#1768) Bump version to 2.16.2 (#1765) Improved code for periodic Autofocus on scan for better cancellation and task handlilng (#1764) Updated Sed expression for Android manifests (#1763) Bumped version to 2.16.1 (#1762) Add iOS Share Extension to our version bump automation (#1761) Bumped version to 2.16.0 (#1760) Improved Autofocus code on ScanPage for better cancellation and exception handling #1228 (#1759) [Help] Update links to new pattern (#1758) Client & Version headers (#1757) Autosync the updated translations (#1752) Fix delete account SSO with CME that the OTP parameter was being sent incorrectly to the server (#1751) [Icons] Fast follower changes (#1750) Removed punctuation on some string resources regarding send (#1747) # Conflicts: # src/Android/Properties/AndroidManifest.xml # src/iOS.Autofill/Info.plist # src/iOS.Extension/Info.plist # src/iOS.ShareExtension/Info.plist # src/iOS/Info.plist
The issue I'm getting happens the second time I try to scan a QR code without restarting the app. The crash message is |
This has been addressed by bitwarden/mobile#1759 and should be resolved in the mobile app v2.16.2. Please let us know if this crash still occurs after this update. I'm leaving this issue open as @vvolkgang mentioned until we can confirm the fix. |
I thought that I installed the update before reporting, but I guess not; this was a mistake on my part. After updating and testing, I can confirm that the latest build fixed the issue for me. |
Happy to see progress on this, but sadly it still occasionally crashes here. Adb logcat also shows Device: Asus Zenphone 3 Zoom (ZE553KL) |
@fmbarina can you provide reproduction steps? We believe that's a different issue and we've been unable to replicate it yet. |
I wish I could provide more helpful information - and do tell me if I'm doing this wrong. But I just...
And upon trying to scan, sometimes it crashes. |
I am also experiencing this issue. The camera works fine until it "sees" the QR code, then the app crashes. (2.16.2 on Xiaomi Mi5s running LineageOS 16, Android 9) |
This issue appears to still be present on version 2.18.0 |
I'm affected by the issue as well, version 2022.05.0 on Pixel 5 running Android 12 (security update May 5, 2022). Bitwarden app crashes on first attempt to scan the QR code; scanning the code after reopening the app after crash succeeds though. |
Thanks a lot for all the feedback, this is happening because of a racing issue so it's quite difficult to reproduce consistently, but a fix has been applied in #1942 and will be available in June's release. Please let us know if this keeps happening after the release, thanks. |
@fedemkr any beta releases before that? |
Hi, @develop7 you can grab the apk from Github Action Artifacts and try it to see if that solves your issue but beware that the app may not be stable given that it's a development build and it hasn't been tested thoroughly by the test team yet. |
Co-authored-by: David Perez <david@livefront.com>
Co-authored-by: David Perez <david@livefront.com>
Describe the Bug
App crash when scanning QR code to add TOTP
Steps To Reproduce
Expected Result
TOTP configured
Actual Result
App crash and back to Android home screen
Screenshots or Videos
Environment
The text was updated successfully, but these errors were encountered: