This repository has been archived by the owner on Feb 19, 2020. It is now read-only.
Fix/fix disabling feedback #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumaxis
approved these changes
Jan 10, 2017
| @@ -219,26 +219,15 @@ typedef NS_ENUM(NSInteger, BITFeedbackObservationMode) { | |||
| This will grab the latest image from the camera roll. Requires iOS 7 or later! It also requires to add a NSPhotoLibraryUsageDescription to your app's Info.plist. | |||
| - `BITFeedbackObservationModeThreeFingerTap`: Triggers when the user taps on the screen with three fingers. Takes a screenshot and attaches it to the composer. It also requires to add a NSPhotoLibraryUsageDescription to your app's Info.plist. | |||
|
|
|||
| Default is `BITFeedbackObservationNone` | |||
| Default is `BITFeedbackObservationNone`. | |||
| If BITFeedbackManger was disabled, setting a new value will be ignored. | |||
There was a problem hiding this comment.
A test for this case might be nice 😊
There was a problem hiding this comment.
It is done ;)
| - (void)setObservationModeThreeFingerTapEnabled:(BOOL)observationModeThreeFingerTapEnabled { | ||
| _observationModeThreeFingerTapEnabled = observationModeThreeFingerTapEnabled; | ||
|
|
||
| if(observationModeThreeFingerTapEnabled) { |
|
|
||
| if (feedbackObservationMode == BITFeedbackObservationModeOnScreenshot) { | ||
| [self setObservationModeOnScreenshotEnabled:YES]; | ||
| if(self.observationModeThreeFingerTapEnabled) { |
|
@lumaxis I was thinking just the same. I was thinking of adding an |
lumaxis
reviewed
Jan 11, 2017
| /** | ||
| * Allows both BITFeedbackObservationModeOnScreenshot and BITFeedbackObservationModeThreeFingerTap at the same time. | ||
| */ | ||
| BITFeedbackObservationModeAll = 3 |
There was a problem hiding this comment.
I think this is not a problem in this specific case but generally I would advise for this to be some other, very high number, 99 or so for example. But since it's unlikely we'll add any more options here, this should be fine 🙂
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description:
Disabling BITFeedbackManager didn't disable BITFeedbackObservationModes.