spirv: derive Hash and impl AsRef#675
Merged
bitshifter merged 3 commits intobitshifter:mainfrom Sep 23, 2025
Merged
Conversation
This was referenced Sep 23, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
#[derive(Hash)]impl AsRef for XXXAll of these features compile successfully on spirv, but may fail to link if they are used by shader code. They don't need to be feature gated explicitly by glam. Removing the feature gate now allows future iterations of the compiler to make the failing constructs work without having to first update glam to remove these feature gates.