Skip to content

Conversation

@nathanielhourt
Copy link
Contributor

@nathanielhourt nathanielhourt commented Aug 22, 2019

Pretty render available here

For reference, the issue is #178.

@abitmore
Copy link
Member

Please don't update README in this PR, but let @ryanRfox do it in another PR. It caused conflicts.

@abitmore
Copy link
Member

Github does the pretty-render job by itself. Click Files changed, then click the "rich text" icon for each file.
image
then
image

Why closed the issue? For example, I'd like to discuss potential use cases there, rather than here, we'd focus on specifications and wording in this PR.

@ryanRfox
Copy link
Contributor

Thanks for removing the README @nathanhourt. I think this is "done" just looking for an review/approval from @pmconrad @abitmore or another.

@ryanRfox
Copy link
Contributor

Oops, checked my notes. @oxarbitrage and/or @christophersanborn was going to make a review/approval of this one. Sorry guys.

Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not consider myself the best person to review BSIPs but this is good enough for me. Will appreciate if someone else can take a look before merging.

I had been over the text several times trying to understand the specifications. There are a lot of options but they all make sense to me initially, i was not able to find any evident flaw.

In development some thing can change but the specifications explain pretty clearly(to someone with some background) the spirit of what is going to be done.

Great work.

Copy link
Contributor

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this best: :-)

Please note that while this specification attempts to provide a sufficient level of technical detail to convey the essence of Tanks and Taps, some detail has been elided for brevity, and the final implementation may diverge from the specification in order to improve the correctness, stability, efficiency, maintainability, or functionality of the Tanks and Taps framework.

Seriously, I think such a new and broad concept needs time to evolve, and it is close to impossible to specify this completely on the drawing board. With this in mind, we should take this BSIP as a basis for an initial implementation and further exploration.

@ryanRfox
Copy link
Contributor

Great job @nathanhourt on this spec. Appreciate your efforts and the reviews by @oxarbitrage and @pmconrad

@ryanRfox ryanRfox merged commit fdfb51e into bitshares:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants