-
Notifications
You must be signed in to change notification settings - Fork 87
Add BSIP 72: Tanks and Taps #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please don't update README in this PR, but let @ryanRfox do it in another PR. It caused conflicts. |
|
Github does the pretty-render job by itself. Click Why closed the issue? For example, I'd like to discuss potential use cases there, rather than here, we'd focus on specifications and wording in this PR. |
|
Oops, checked my notes. @oxarbitrage and/or @christophersanborn was going to make a review/approval of this one. Sorry guys. |
oxarbitrage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not consider myself the best person to review BSIPs but this is good enough for me. Will appreciate if someone else can take a look before merging.
I had been over the text several times trying to understand the specifications. There are a lot of options but they all make sense to me initially, i was not able to find any evident flaw.
In development some thing can change but the specifications explain pretty clearly(to someone with some background) the spirit of what is going to be done.
Great work.
pmconrad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this best: :-)
Please note that while this specification attempts to provide a sufficient level of technical detail to convey the essence of Tanks and Taps, some detail has been elided for brevity, and the final implementation may diverge from the specification in order to improve the correctness, stability, efficiency, maintainability, or functionality of the Tanks and Taps framework.
Seriously, I think such a new and broad concept needs time to evolve, and it is close to impossible to specify this completely on the drawing board. With this in mind, we should take this BSIP as a basis for an initial implementation and further exploration.
|
Great job @nathanhourt on this spec. Appreciate your efforts and the reviews by @oxarbitrage and @pmconrad |


Pretty render available here
For reference, the issue is #178.