Fixing wrong precision over accumulated collateral fees amount #3664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
requested changes
Sep 5, 2023
| claimCollateralFeesAmountAsset: new Asset({ | ||
| amount: 0, | ||
| precision: this.props.asset.get("precision"), | ||
| precision: this.props.core.get("precision"), |
There was a problem hiding this comment.
This looks wrong. In fact, the asset type of the collateral fee is just the backing asset (see code below), it could be another asset, but not only core.
|
Stale, if you want to continue please pick up the review comments and finalize |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing wrong precision over accumulated collateral fees amount (TEXT BOX).