Skip to content

BSIP 86 Fee max of 30% #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abitmore merged 1 commit into from
Apr 27, 2020
Merged

BSIP 86 Fee max of 30% #2140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libraries/protocol/chain_parameters.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ namespace graphene { namespace protocol {
"Committee proposal review period must be less than the maximum proposal lifetime" );
if( extensions.value.market_fee_network_percent.valid() )
{
FC_ASSERT( *extensions.value.market_fee_network_percent <= GRAPHENE_100_PERCENT,
"The market_fee_network_percent parameter can not exceed 100%" );
FC_ASSERT( *extensions.value.market_fee_network_percent <= 3000, // GRAPHENE_100_PERCENT is 10000
"The market_fee_network_percent parameter can not exceed 30%" );
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/tests/bsip86_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ BOOST_AUTO_TEST_CASE( hardfork_time_test )
cop.fee_paying_account = GRAPHENE_TEMP_ACCOUNT;
cop.expiration_time = db.head_block_time() + *cop.review_period_seconds + 10;
committee_member_update_global_parameters_operation cmuop;
cmuop.new_parameters.extensions.value.market_fee_network_percent = 10001; // 100.01%
cmuop.new_parameters.extensions.value.market_fee_network_percent = 3001; // 30.01%
cop.proposed_ops.emplace_back(cmuop);
trx.operations.push_back(cop);

Expand Down