Change call_order_update_operation to return order_id #1269 - #1352
Conversation
jmjatlanta
left a comment
jmjatlanta
left a comment
There was a problem hiding this comment.
I am not sure what should be done in this case. Should we be returning an ID of something that no longer exists? If no, what should we return?
| FC_ASSERT( new_collateral == 0, "Should claim all collateral when closing debt position" ); | ||
| d.remove( *call_obj ); | ||
| return void_result(); | ||
| return call_order_id; |
There was a problem hiding this comment.
Should we return the id of a deleted object?
There was a problem hiding this comment.
why not ? :) IMHO the id of a deleted object may be helpful for looking history of that object, even it is better than return nothing ...
There was a problem hiding this comment.
Agree, makes sense to return it.
| _bitasset_data->current_feed.maintenance_collateral_ratio ); | ||
| call.target_collateral_ratio = o.extensions.value.target_collateral_ratio; | ||
| }); | ||
| call_order_id = call_obj->id; |
There was a problem hiding this comment.
This is superfluous, modify() will not change the id.
|
any other changes must be here or we can approve and merge this PR ? Thanks a lot ! |
|
Thanks for review ! Thank you very much for your time and efforts ! |
4 participants
PR for #1269 "Change call_order_update_operation to return order_id"