unsigned_int unpacking - #1267
Merged
Merged
Conversation
abitmore
reviewed
Aug 19, 2018
| template<> struct js_name<fc::sha224> { static std::string name(){ return "bytes 28"; } }; | ||
| template<> struct js_name<fc::sha256> { static std::string name(){ return "bytes 32"; } }; | ||
| template<> struct js_name<fc::unsigned_int> { static std::string name(){ return "varuint32"; } }; | ||
| template<> struct js_name<fc::signed_int> { static std::string name(){ return "varint32"; } }; |
Member
There was a problem hiding this comment.
Actually JS code is using varint32 everywhere but not varuint32. Will submit an issue there.
Contributor
Author
There was a problem hiding this comment.
Hm, should we rename that to varuint64?
Member
There was a problem hiding this comment.
Yes, I think so.
JS code need to be fixed anyway.
Member
Restarted. |
abitmore
approved these changes
Aug 23, 2018
This was referenced Aug 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #993 and #1088.
TODO: