update bnb log #1661
update bnb log #1661
Conversation
bitsandbytes/cextension.py
Outdated
| "IPEX is recommended for Intel XPU support in bitsandbytes to get better performance. " | ||
| "Please check the installation doc to install `intel_extension_for_pytorch`. " | ||
| ) | ||
| lib = ErrorHandlerMockBNBNativeLibrary("XPU does not need native library") |
There was a problem hiding this comment.
why need ErrorHandlerMockBNBNativeLibrary
There was a problem hiding this comment.
I thought it was the default lib, but we can just set lib=None since XPU will not use lib.
bitsandbytes/cextension.py
Outdated
| if not ipex_xpu: | ||
| logger.warning( | ||
| "Detected Intel XPU but no Intel Extension for PyTorch (IPEX) installed. " | ||
| "IPEX is recommended for Intel XPU support in bitsandbytes to get better performance. " |
There was a problem hiding this comment.
Can we please mention Triton here?
For example: "XPU is detected, but IPEX is missing, will try to use Trtiton implementation. If performance is lower your expectations, consider installing IPEX"
The current wording effectively prohibits the use of XPU without IPEX.
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
matthewdouglas
added
the
Low Risk
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
We need to use mock lib because of the functional variable. |
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
|
Hi @matthewdouglas . This PR is ready to be reviewed, please let me know your comments. Thanks! |
|
I don't think we should push user into a specific XPU backend, until we clearly know which one is likely faster. |
Update the error message when xpu is available, we don't need native library on XPU
@matthewdouglas Please review it. Thanks!