Cuda source cleanup , refactor and fixes #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! We actually just recently were discussing some cleanup here so this fits nicely timing-wise! |
|
Thanks for the PR, really appreciate the pro-activity in helping us clean things up! I just had a chat with Tim and he reviewed the PR and said everything looks good to him. I see you put the PR as draft, are there any more changes coming or can wrap things up? |
|
Hi @Titus-von-Koeller , I am planning to wrap this up in a couple of hours from now. |
|
@Titus-von-Koeller this is ready for review now, thanks. |
abhilash1910
changed the title
matthewdouglas
merged commit 6bef412
into
bitsandbytes-foundation:main
28 checks passed
matthewdouglas
pushed a commit
to matthewdouglas/bitsandbytes
that referenced
this pull request
Oct 28, 2024
Cuda source cleanup , refactor and fixes (bitsandbytes-foundation#1328) * remove kcompress * fix initial template call * fix function name * remove vector load * cleanup reduce & rearrange * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft Pr for cleanup of cuda kernels, refactor template assignments and fix some AOT issues.
The cuda kernels have some scope of cleanup in terms of redundant code pathways and unused methods.
cc @matthewdouglas , @Titus-von-Koeller
@TimDettmers (pinging for awareness).