Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define CUDA versions for workflows centrally #1052

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Define CUDA versions for workflows centrally #1052

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
04a3a05
Define CUDA version in dockerfile to allow Dependabot to pick it up
rickardp Feb 7, 2024
1acc07e
Added dependabot section
rickardp Feb 7, 2024
efcd78f
Use Python for parsing Dockerfile
rickardp Feb 27, 2024
530676c
Merge branch 'main' into dockerfile
rickardp Feb 27, 2024
2889393
Update get_docker_info.py
rickardp Mar 29, 2024
1243718
Update python-package.yml
rickardp Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added dependabot section
  • Loading branch information
@rickardp
rickardp committed Feb 7, 2024
commit 1acc07ec5c7607278d389feea10194ebe98bc432
6 changes: 6 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,9 @@ updates:
update-types: [major]
minor-patch:
update-types: [minor, patch]
- package-ecosystem: docker
directory: "/docker"
schedule:
interval: "weekly"
ignore:
- update-types: [ "version-update:semver-major" ]
10 changes: 6 additions & 4 deletions .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ jobs:
- os: windows-latest # This probably requires arm64 Windows agents
arch: aarch64
runs-on: ${{ matrix.os }} # One day, we could run them on native agents. Azure supports this now but it's planned only for Q3 2023 for hosted agents
env:
CUDA_VERSION: notset
steps:
# Check out code
- uses: actions/checkout@v4
Expand Down Expand Up @@ -100,7 +102,7 @@ jobs:
- name: Set CUDA version
shell: bash
run: |
cuda_version=$(scripts/get_docker_info.sh docker/cuda.Dockerfile cuda${{ matrix.cuda_version }})
cuda_version=$(scripts/get_docker_info.sh -v docker/cuda.Dockerfile cuda${{ matrix.cuda_version }} | sed -e 's/-.*//')
echo "CUDA version to use is $cuda_version"
echo "CUDA_VERSION=$cuda_version" >> $GITHUB_ENV
# On Linux we use CMake within Docker
Expand All @@ -118,7 +120,7 @@ jobs:
if: startsWith(matrix.os, 'windows')
id: cuda-toolkit
with:
cuda: ${{ vars.CUDA_VERSION }}
cuda: ${{ env.CUDA_VERSION }}
method: 'local'
# sub-packages: '["nvcc","cudart","nvrtc_dev","cublas_dev","cusparse_dev","visual_studio_integration"]'
- name: Add msbuild to PATH
Expand All @@ -140,7 +142,7 @@ jobs:
build_arch=${{ matrix.arch }}
for NO_CUBLASLT in ON OFF; do
if [ ${build_os:0:6} == ubuntu ]; then
image=nvidia/cuda:${{ vars.CUDA_VERSION }}-devel-ubuntu22.04
image=nvidia/cuda:${{ env.CUDA_VERSION }}-devel-ubuntu22.04
echo "Using image $image"
docker run --platform linux/$build_arch -i -w /src -v $PWD:/src $image sh -c \
"apt-get update \
Expand All @@ -157,7 +159,7 @@ jobs:
- name: Upload build artifact
uses: actions/upload-artifact@v4
with:
name: shared_library_cuda_${{ matrix.os }}_${{ matrix.arch }}_${{ vars.CUDA_VERSION }}
name: shared_library_cuda_${{ matrix.os }}_${{ matrix.arch }}_${{ env.CUDA_VERSION }}
path: output/*
retention-days: 7
build-wheels:
Expand Down
Loading