Skip to content

Conversation

ashkew2202
Copy link
Contributor

@ashkew2202 ashkew2202 commented Aug 25, 2025

Pull Request Template for Pollz Backend

✏️ Summary of Changes

A yaml file for testing code before every push or pull request to main is coded along with some basic django tests. The test for razor pay is not configured.

📦 Dependencies

To test this locally i used act but other than that no extra dependencies are required

🐛 Related Issues

This should close issue #7 and #3.

📋 Checklist

  • I have tested my changes locally
  • I have updated documentation if necessary
  • My code follows the project's coding standards
  • I have run migrations if database changes were made
  • I have updated requirements.txt if new dependencies were added
  • I have tested with Docker Compose setup
  • Environment variables are properly configured

📝 Additional Notes

All unauthorized API calls ( which require a user ) are tested by django tests rest basic GET method based which does not require a user are implemented by bruno cli testing and did confirm that all those APIs are giving 200 OK response on testing.
The database used in this pipeline is configured to be a temporary DB which is also populated by using the management commands. The only thing left is filtering which API calls are not gonna respond with 200 OK in the yaml as many of those APIs are still giving bad responses with bruno cli testing.

@madmecodes
Copy link
Contributor

Thnx for the PR, will review it shortly

@ashkew2202
Copy link
Contributor Author

When will this PR be merged?

@madmecodes
Copy link
Contributor

bin folder is still commited u need to remove it from cache ig command is something like git rm --cached, pls check

@madmecodes
Copy link
Contributor

@anshalshukla thnx for the PR and the reminder, i can see good changes

  • Comprehensive CI/CD pipeline
  • Bruno API testing integration
  • Django test coverage expansion

can you please look into the review comments and take time to fix it whenever you get time?

@ashkew2202
Copy link
Contributor Author

@madmecodes I removed the bin folder, you can review it now. Sorry for the rookie mistake.

@madmecodes
Copy link
Contributor

Screenshot 2025-09-02 at 10 29 19 PM Np, what about review comments?

Copy link
Contributor Author

@ashkew2202 ashkew2202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see any reviews

@ashkew2202
Copy link
Contributor Author

I cannot see any reviews on my PR.

@madmecodes
Copy link
Contributor

I cannot see any reviews on my PR.

go to file change tab arent they visible there?

@ashkew2202
Copy link
Contributor Author

I cannot see any reviews on my PR.

go to file change tab arent they visible there?

image I tried that I actually cannot

# wait for server to be responsive (up to ~120 seconds)
for i in $(seq 1 ); do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it complete?? like must be (seq 1 30)

POSTGRES_DB=pollz_db
POSTGRES_USER=pollz_user
POSTGRES_PASSWORD=your-postgres-password-here
POSTGRES_HOST=your-host
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isnt in .env why do we need these vars are we using them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants