-
Notifications
You must be signed in to change notification settings - Fork 10
Ci Cd workflow with Bruno API testing #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ight or not by running tests but will code some tests later
…ight or not by running tests but will code some tests later
…I calls which require auth are not configured to be tested in the workflow
…backend into ci-cd-workflow
Thnx for the PR, will review it shortly |
When will this PR be merged? |
bin folder is still commited u need to remove it from cache ig command is something like git rm --cached, pls check |
@anshalshukla thnx for the PR and the reminder, i can see good changes
can you please look into the review comments and take time to fix it whenever you get time? |
@madmecodes I removed the bin folder, you can review it now. Sorry for the rookie mistake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot see any reviews
I cannot see any reviews on my PR. |
go to file change tab arent they visible there? |
# wait for server to be responsive (up to ~120 seconds) | ||
for i in $(seq 1 ); do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it complete?? like must be (seq 1 30)
POSTGRES_DB=pollz_db | ||
POSTGRES_USER=pollz_user | ||
POSTGRES_PASSWORD=your-postgres-password-here | ||
POSTGRES_HOST=your-host |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isnt in .env why do we need these vars are we using them?
Pull Request Template for Pollz Backend
✏️ Summary of Changes
A yaml file for testing code before every push or pull request to main is coded along with some basic django tests. The test for razor pay is not configured.
📦 Dependencies
To test this locally i used act but other than that no extra dependencies are required
🐛 Related Issues
This should close issue #7 and #3.
📋 Checklist
📝 Additional Notes
All unauthorized API calls ( which require a user ) are tested by django tests rest basic GET method based which does not require a user are implemented by bruno cli testing and did confirm that all those APIs are giving 200 OK response on testing.
The database used in this pipeline is configured to be a temporary DB which is also populated by using the management commands. The only thing left is filtering which API calls are not gonna respond with 200 OK in the yaml as many of those APIs are still giving bad responses with bruno cli testing.