feat: ACI-3938 Activate xcode step #2
Conversation
SummaryThis PR adds the Activate Bitrise Build Cache for Xcode step, including the main step script, configuration files, and end-to-end testing setup. The implementation downloads and configures the Bitrise Build Cache CLI with fallback mechanisms. Walkthrough
|
bitrise-ip-bot
left a comment
bitrise-ip-bot
left a comment
There was a problem hiding this comment.
This is an AI-generated review. Please review it carefully.
Actionable comments posted: 4
bitrise-ip-bot
left a comment
bitrise-ip-bot
left a comment
There was a problem hiding this comment.
This is an AI-generated review. Please review it carefully.
Actionable comments posted: 1
e2e/bitrise.yml
Outdated
| inputs: | ||
| - repository_url: $TEST_APP_URL | ||
| - clone_into_dir: ./_tmp | ||
| - main: $BRANCH |
There was a problem hiding this comment.
🐛 Bug
Invalid parameter name 'main' for bitrise-step-simple-git-clone step. The correct parameter name should be 'branch'.
🔄 Suggestion:
| - main: $BRANCH | |
| - branch: $BRANCH |
bitrise-ip-bot
left a comment
bitrise-ip-bot
left a comment
There was a problem hiding this comment.
This is an AI-generated review. Please review it carefully.
Actionable comments posted: 1
e2e/bitrise.yml
Outdated
| inputs: | ||
| - repository_url: $TEST_APP_URL | ||
| - clone_into_dir: ./_tmp | ||
| - main: $BRANCH |
There was a problem hiding this comment.
🐛 Bug
Invalid parameter name 'main' for bitrise-step-simple-git-clone step. The correct parameter name should be 'branch'.
🔄 Suggestion:
| - main: $BRANCH | |
| - branch: $BRANCH |
bitrise-ip-bot
left a comment
bitrise-ip-bot
left a comment
There was a problem hiding this comment.
This is an AI-generated review. Please review it carefully.
Actionable comments posted: 1
step.sh
Outdated
| # run the Bitrise Build Cache CLI | ||
| /tmp/bin/bitrise-build-cache activate xcode --debug="$verbose" | ||
|
|
||
| source "~/.bashrc" |
There was a problem hiding this comment.
🐛 Bug
The literal tilde path won't expand properly in this context. The script will fail to source the bashrc file because the tilde is not expanded to the user's home directory.
🔄 Suggestion:
| source "~/.bashrc" | |
| source "$HOME/.bashrc" |
bitrise-ip-bot
left a comment
bitrise-ip-bot
left a comment
There was a problem hiding this comment.
This is an AI-generated review. Please review it carefully.
Actionable comments posted: 1
step.sh
Outdated
| # run the Bitrise Build Cache CLI | ||
| /tmp/bin/bitrise-build-cache activate xcode --debug="$verbose" | ||
|
|
||
| alias xcodebuild='~/.bitrise-xcelerate/bin/bitrise-build-cache-cli xcelerate xcodebuild' |
There was a problem hiding this comment.
🐛 Bug
Alias path mismatch will cause xcodebuild alias to fail in production. The alias points to ~/.bitrise-xcelerate/bin/bitrise-build-cache-cli but the CLI is downloaded to /tmp/bin/bitrise-build-cache.
🔄 Suggestion:
| alias xcodebuild='~/.bitrise-xcelerate/bin/bitrise-build-cache-cli xcelerate xcodebuild' | |
| alias xcodebuild='/tmp/bin/bitrise-build-cache xcelerate xcodebuild' |
bitrise-ip-bot
left a comment
bitrise-ip-bot
left a comment
There was a problem hiding this comment.
This is an AI-generated review. Please review it carefully.
Actionable comments posted: 1
bitrise-ip-bot
left a comment
bitrise-ip-bot
left a comment
There was a problem hiding this comment.
This is an AI-generated review. Please review it carefully.
Actionable comments posted: 1
bitrise-ip-bot
left a comment
bitrise-ip-bot
left a comment
There was a problem hiding this comment.
This is an AI-generated review. Please review it carefully.
Actionable comments posted: 1
bitrise-ip-bot
left a comment
bitrise-ip-bot
left a comment
There was a problem hiding this comment.
This is an AI-generated review. Please review it carefully.
Actionable comments posted: 3
Checklist
step.ymlandREADME.mdis updated with the changes (if needed)Version
Requires a MAJOR/MINOR/PATCH version update
Context
Changes
Investigation details
Decisions