[ACI-4171] Make IosBaseApplication provisioning optional (simulator builds) #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SummaryThis PR modifies iOS application provisioning profile handling to make it optional for simulator builds. The change allows creating IosBaseApplication instances even when no embedded.mobileprovision file is found, which helps share code between build-for-simulator and archive steps. Walkthrough
|
Badlazzor
changed the title
Comment on lines
+68
to
73
| provisioningProfile, err := provisioningProfileCreator() | ||
| if err != nil && err != profileNotFoundErr { | ||
| return IosBaseApplication{}, err | ||
| } else if err == profileNotFoundErr { | ||
| log.Printf("No embedded.mobileprovision found for app at: %s", path) | ||
| } |
There was a problem hiding this comment.
🐛 Bug
This change allows creating IosBaseApplication with a zero-value ProvisioningProfile when no embedded.mobileprovision is found. However, the IsXcodeManaged() method (line 310) calls ProvisioningProfile.IsXcodeManaged() directly without checking if the profile is valid, which will cause runtime issues for simulator builds.
🔄 Suggestion:
Suggested change
| provisioningProfile, err := provisioningProfileCreator() | |
| if err != nil && err != profileNotFoundErr { | |
| return IosBaseApplication{}, err | |
| } else if err == profileNotFoundErr { | |
| log.Printf("No embedded.mobileprovision found for app at: %s", path) | |
| } | |
| provisioningProfile, err := provisioningProfileCreator() | |
| if err != nil && err != profileNotFoundErr { | |
| return IosBaseApplication{}, err | |
| } else if err == profileNotFoundErr { | |
| log.Printf("No embedded.mobileprovision found for app at: %s", path) | |
| // Note: IsXcodeManaged() method needs to be updated to handle zero-value ProvisioningProfile | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps making it possible to share code between the
build-for-simulatorandarchivesteps.