Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool 1904 validate spec #2431

Merged
merged 29 commits into from
Mar 31, 2020
Merged

Tool 1904 validate spec #2431

merged 29 commits into from
Mar 31, 2020

Conversation

godrei
Copy link
Contributor

@godrei godrei commented Mar 23, 2020

Introducing JSON schema check against the generated StepLib spec.

@godrei godrei requested a review from a team March 24, 2020 08:20
@ghost ghost requested review from Szabadember and removed request for a team March 24, 2020 08:20
@godrei godrei requested a review from trapacska March 24, 2020 12:27
handlers/validate-spec/main_test.go Outdated Show resolved Hide resolved
handlers/validate-spec/main_test.go Outdated Show resolved Hide resolved
handlers/validate-spec/main_test.go Outdated Show resolved Hide resolved
Remove unnecessary logging, update test names, move expected err to variable.
@godrei godrei requested a review from Szabadember March 24, 2020 12:32
handlers/validate-spec/main.go Outdated Show resolved Hide resolved
handlers/validate-spec/step.yml Outdated Show resolved Hide resolved
handlers/validate-spec/main.go Outdated Show resolved Hide resolved
handlers/validate-spec/main.go Outdated Show resolved Hide resolved
schema.json Outdated Show resolved Hide resolved
schema.json Outdated Show resolved Hide resolved
schema.json Outdated Show resolved Hide resolved
schema.json Outdated Show resolved Hide resolved
schema.json Outdated Show resolved Hide resolved
schema.json Outdated Show resolved Hide resolved
godrei added 4 commits March 25, 2020 09:33
Rename spec to spec_path, introduce schema_path step input.
@godrei godrei requested a review from trapacska March 25, 2020 10:51
trapacska
trapacska previously approved these changes Mar 25, 2020
Szabadember
Szabadember previously approved these changes Mar 25, 2020
@godrei godrei requested review from trapacska and Szabadember March 30, 2020 10:01
@godrei godrei merged commit cacdb28 into master Mar 31, 2020
@godrei godrei deleted the TOOL-1904-validate-spec branch May 28, 2020 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants