Skip to content

Remove Visual from BitButtonTests (#4105) #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msynk merged 1 commit into from
Mar 21, 2023
Merged

Remove Visual from BitButtonTests (#4105) #4112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 39 additions & 56 deletions src/BlazorUI/Bit.BlazorUI.Tests/Buttons/BitButtonTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Bunit;
using System;
using Bunit;
using Microsoft.AspNetCore.Components.Forms;
using Microsoft.VisualStudio.TestTools.UnitTesting;

Expand All @@ -8,27 +9,16 @@ namespace Bit.BlazorUI.Tests.Buttons;
public class BitButtonTests : BunitTestContext
{
[DataTestMethod,
DataRow(Visual.Fluent, true, BitButtonStyle.Primary, "title"),
DataRow(Visual.Fluent, true, BitButtonStyle.Standard, "title"),
DataRow(Visual.Fluent, false, BitButtonStyle.Primary, "title"),
DataRow(Visual.Fluent, false, BitButtonStyle.Standard, "title"),

DataRow(Visual.Cupertino, true, BitButtonStyle.Primary, "title"),
DataRow(Visual.Cupertino, true, BitButtonStyle.Standard, "title"),
DataRow(Visual.Cupertino, false, BitButtonStyle.Primary, "title"),
DataRow(Visual.Cupertino, false, BitButtonStyle.Standard, "title"),

DataRow(Visual.Material, true, BitButtonStyle.Primary, "title"),
DataRow(Visual.Material, true, BitButtonStyle.Standard, "title"),
DataRow(Visual.Material, false, BitButtonStyle.Primary, "title"),
DataRow(Visual.Material, false, BitButtonStyle.Standard, "title"),
DataRow(true, BitButtonStyle.Primary, "title"),
DataRow(true, BitButtonStyle.Standard, "title"),
DataRow(false, BitButtonStyle.Primary, "title"),
DataRow(false, BitButtonStyle.Standard, "title")
]
public void BitButtonTest(Visual visual, bool isEnabled, BitButtonStyle style, string title)
public void BitButtonTest(bool isEnabled, BitButtonStyle style, string title)
{
var clicked = false;
var com = RenderComponent<BitButton>(parameters =>
{
parameters.AddCascadingValue(visual);
parameters.Add(p => p.IsEnabled, isEnabled);
parameters.Add(p => p.ButtonStyle, style);
parameters.Add(p => p.Title, title);
Expand All @@ -54,28 +44,25 @@ public void BitButtonTest(Visual visual, bool isEnabled, BitButtonStyle style, s
}

[DataTestMethod,
DataRow(Visual.Fluent, BitButtonSize.Small),
DataRow(Visual.Fluent, BitButtonSize.Medium),
DataRow(Visual.Fluent, BitButtonSize.Large),

DataRow(Visual.Cupertino, BitButtonSize.Small),
DataRow(Visual.Cupertino, BitButtonSize.Medium),
DataRow(Visual.Cupertino, BitButtonSize.Large),

DataRow(Visual.Material, BitButtonSize.Small),
DataRow(Visual.Material, BitButtonSize.Medium),
DataRow(Visual.Material, BitButtonSize.Large)
DataRow(BitButtonSize.Small),
DataRow(BitButtonSize.Medium),
DataRow(BitButtonSize.Large)
]
public void BitButtonSizeTest(Visual visual, BitButtonSize size)
public void BitButtonSizeTest(BitButtonSize size)
{
var com = RenderComponent<BitButton>(parameters =>
{
parameters.AddCascadingValue(visual);
parameters.Add(p => p.ButtonSize, size);
});

var bitButton = com.Find(".bit-btn");
var sizeClass = size == BitButtonSize.Small ? "small" : size == BitButtonSize.Medium ? "medium" : "large";
var bitButton = com.Find(".bit-btn");
var sizeClass = size switch
{
BitButtonSize.Small => "small",
BitButtonSize.Medium => "medium",
BitButtonSize.Large => "large",
_ => throw new NotSupportedException()
};

Assert.IsTrue(bitButton.ClassList.Contains(sizeClass));
}
Expand All @@ -97,37 +84,26 @@ public void BitButtonDisabledFocusTest(bool isEnabled, BitButtonStyle style, boo

var bitButton = com.Find(".bit-btn");

var hasTabindexAttr = bitButton.HasAttribute("tabindex");
var hasTabIndexAttr = bitButton.HasAttribute("tabindex");

Assert.AreEqual(hasTabindexAttr, expectedResult);
Assert.AreEqual(hasTabIndexAttr, expectedResult);

if (hasTabindexAttr)
if (hasTabIndexAttr)
{
Assert.IsTrue(bitButton.GetAttribute("tabindex").Equals("-1"));
}
}

[DataTestMethod,
DataRow(Visual.Fluent, true, BitButtonStyle.Primary, "https://github.com/bitfoundation", "bit", "_blank"),
DataRow(Visual.Fluent, true, BitButtonStyle.Standard, "https://github.com/bitfoundation", "bit", "_blank"),
DataRow(Visual.Fluent, false, BitButtonStyle.Primary, "https://github.com/bitfoundation", "bit", "_blank"),
DataRow(Visual.Fluent, false, BitButtonStyle.Standard, "https://github.com/bitfoundation", "bit", "_blank"),

DataRow(Visual.Cupertino, true, BitButtonStyle.Primary, "https://github.com/bitfoundation", "bit", "_blank"),
DataRow(Visual.Cupertino, true, BitButtonStyle.Standard, "https://github.com/bitfoundation", "bit", "_blank"),
DataRow(Visual.Cupertino, false, BitButtonStyle.Primary, "https://github.com/bitfoundation", "bit", "_blank"),
DataRow(Visual.Cupertino, false, BitButtonStyle.Standard, "https://github.com/bitfoundation", "bit", "_blank"),

DataRow(Visual.Material, true, BitButtonStyle.Primary, "https://github.com/bitfoundation", "bit", "_blank"),
DataRow(Visual.Material, true, BitButtonStyle.Standard, "https://github.com/bitfoundation", "bit", "_blank"),
DataRow(Visual.Material, false, BitButtonStyle.Primary, "https://github.com/bitfoundation", "bit", "_blank"),
DataRow(Visual.Material, false, BitButtonStyle.Standard, "https://github.com/bitfoundation", "bit", "_blank"),
DataRow(true, BitButtonStyle.Primary, "https://github.com/bitfoundation", "bit", "_blank"),
DataRow(true, BitButtonStyle.Standard, "https://github.com/bitfoundation", "bit", "_blank"),
DataRow(false, BitButtonStyle.Primary, "https://github.com/bitfoundation", "bit", "_blank"),
DataRow(false, BitButtonStyle.Standard, "https://github.com/bitfoundation", "bit", "_blank")
]
public void BitAnchorButtonTest(Visual visual, bool isEnabled, BitButtonStyle style, string href, string title, string target)
public void BitAnchorButtonTest(bool isEnabled, BitButtonStyle style, string href, string title, string target)
{
var com = RenderComponent<BitButton>(parameters =>
{
parameters.AddCascadingValue(visual);
parameters.Add(p => p.IsEnabled, isEnabled);
parameters.Add(p => p.ButtonStyle, style);
parameters.Add(p => p.Href, href);
Expand Down Expand Up @@ -204,7 +180,14 @@ public void BitButtonTypeOfButtonTest(BitButtonType buttonType)

var bitButton = com.Find(".bit-btn");

var buttonTypeName = buttonType == BitButtonType.Button ? "button" : buttonType == BitButtonType.Submit ? "submit" : "reset";
var buttonTypeName = buttonType switch
{
BitButtonType.Button => "button",
BitButtonType.Submit => "submit",
BitButtonType.Reset => "reset",
_ => throw new NotSupportedException(),
};

Assert.AreEqual(buttonTypeName, bitButton.GetAttribute("type"));
}

Expand All @@ -215,21 +198,21 @@ public void BitButtonSubmitStateInEditContextTest()
{
parameters.Add(p => p.EditContext, new EditContext(this));
});

var bitButton = com.Find(".bit-btn");

Assert.AreEqual("submit", bitButton.GetAttribute("type"));
}

[TestMethod]
public void BitButtonButtonStateNotOverridenInEditContextTest()
public void BitButtonButtonStateNotOverriddenInEditContextTest()
{
var com = RenderComponent<BitButton>(parameters =>
{
parameters.Add(p => p.EditContext, new EditContext(this));
parameters.Add(p => p.ButtonType, BitButtonType.Button);
});

var bitButton = com.Find(".bit-btn");

Assert.AreEqual("button", bitButton.GetAttribute("type"));
Expand Down