Skip to content

Remove Visual from BitActionButtonTests (#4106) #4111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msynk merged 2 commits into from
Mar 21, 2023
Merged

Remove Visual from BitActionButtonTests (#4106) #4111

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b1b1f7
Remove Visual from BitActionButtonTests (#4106)
Cyrus-Sushiant Mar 21, 2023
1643130
Clean code
Cyrus-Sushiant Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 21 additions & 20 deletions src/BlazorUI/Bit.BlazorUI.Tests/Buttons/BitActionButtonTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Bunit;
using System;
using Bunit;
using Microsoft.AspNetCore.Components.Forms;
using Microsoft.VisualStudio.TestTools.UnitTesting;

Expand All @@ -8,21 +9,14 @@ namespace Bit.BlazorUI.Tests.Buttons;
public class BitActionButtonTests : BunitTestContext
{
[DataTestMethod,
DataRow(Visual.Fluent, true, BitIconName.AddFriend, "title"),
DataRow(Visual.Fluent, false, BitIconName.AddFriend, "title"),

DataRow(Visual.Cupertino, true, BitIconName.AddFriend, "title"),
DataRow(Visual.Cupertino, false, BitIconName.AddFriend, "title"),

DataRow(Visual.Material, true, BitIconName.AddFriend, "title"),
DataRow(Visual.Material, false, BitIconName.AddFriend, "title"),
DataRow(true, BitIconName.AddFriend, "title"),
DataRow(false, BitIconName.AddFriend, "title")
]
public void BitActionButtonTest(Visual visual, bool isEnabled, BitIconName iconName, string title)
public void BitActionButtonTest(bool isEnabled, BitIconName iconName, string title)
{
var clicked = false;
var com = RenderComponent<BitActionButton>(parameters =>
{
parameters.AddCascadingValue(visual);
parameters.Add(p => p.IsEnabled, isEnabled);
parameters.Add(p => p.IconName, iconName);
parameters.Add(p => p.Title, title);
Expand Down Expand Up @@ -66,11 +60,11 @@ public void BitActionButtonDisabledFocusTest(bool isEnabled, bool allowDisabledF

var bitButton = com.Find(".bit-acb");

var hasTabindexAttr = bitButton.HasAttribute("tabindex");
var hasTabIndexAttr = bitButton.HasAttribute("tabindex");

Assert.AreEqual(hasTabindexAttr, expectedResult);
Assert.AreEqual(hasTabIndexAttr, expectedResult);

if (hasTabindexAttr)
if (hasTabIndexAttr)
{
Assert.IsTrue(bitButton.GetAttribute("tabindex").Equals("-1"));
}
Expand Down Expand Up @@ -150,32 +144,39 @@ public void BitActionButtonTypeOfButtonTest(BitButtonType buttonType)

var bitActionButton = component.Find(".bit-acb");

var buttonTypeName = buttonType == BitButtonType.Button ? "button" : buttonType == BitButtonType.Submit ? "submit" : "reset";
var buttonTypeName = buttonType switch
{
BitButtonType.Button => "button",
BitButtonType.Submit => "submit",
BitButtonType.Reset => "reset",
_ => throw new NotSupportedException(),
};

Assert.AreEqual(buttonTypeName, bitActionButton.GetAttribute("type"));
}

[TestMethod]
public void BitActionButtonSubmitStateInEditContextTest()
{
var com = RenderComponent<BitActionButton>(parameters =>
{
parameters.Add(p => p.EditContext, new EditContext(this));
});

var bitButton = com.Find(".bit-acb");

Assert.AreEqual("submit", bitButton.GetAttribute("type"));
}

[TestMethod]
public void BitActionButtonButtonStateNotOverridenInEditContextTest()
public void BitActionButtonButtonStateNotOverriddenInEditContextTest()
{
var com = RenderComponent<BitActionButton>(parameters =>
{
parameters.Add(p => p.EditContext, new EditContext(this));
parameters.Add(p => p.ButtonType, BitButtonType.Button);
});

var bitButton = com.Find(".bit-acb");

Assert.AreEqual("button", bitButton.GetAttribute("type"));
Expand Down