Skip to content

Improved bit resx translator logging configuration (#11785) #11786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ysmoradi merged 1 commit into from
Dec 2, 2025
Merged

Improved bit resx translator logging configuration (#11785) #11786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ResxTranslator/Bit.ResxTranslator/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,18 @@
#endif
configuration.AddCommandLine(args);

services.AddOptions<ResxTranslatorSettings>()

Check warning on line 27 in src/ResxTranslator/Bit.ResxTranslator/Program.cs

View workflow job for this annotation

GitHub Actions / build Bit.ResxTranslator 

Using member 'Microsoft.Extensions.DependencyInjection.OptionsBuilderDataAnnotationsExtensions.ValidateDataAnnotations<TOptions>(OptionsBuilder<TOptions>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Uses DataAnnotationValidateOptions which is unsafe given that the options type passed in when calling Validate cannot be statically analyzed so its members may be trimmed.

Check warning on line 27 in src/ResxTranslator/Bit.ResxTranslator/Program.cs

View workflow job for this annotation

GitHub Actions / build Bit.ResxTranslator 

Using member 'Microsoft.Extensions.DependencyInjection.OptionsBuilderConfigurationExtensions.Bind<TOptions>(OptionsBuilder<TOptions>, IConfiguration)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. Binding strongly typed objects to configuration values may require generating dynamic code at runtime.

Check warning on line 27 in src/ResxTranslator/Bit.ResxTranslator/Program.cs

View workflow job for this annotation

GitHub Actions / build Bit.ResxTranslator 

Using member 'Microsoft.Extensions.DependencyInjection.OptionsBuilderConfigurationExtensions.Bind<TOptions>(OptionsBuilder<TOptions>, IConfiguration)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. TOptions's dependent types may have their members trimmed. Ensure all required members are preserved.

Check warning on line 27 in src/ResxTranslator/Bit.ResxTranslator/Program.cs

View workflow job for this annotation

GitHub Actions / build Bit.ResxTranslator 

Using member 'Microsoft.Extensions.DependencyInjection.OptionsBuilderDataAnnotationsExtensions.ValidateDataAnnotations<TOptions>(OptionsBuilder<TOptions>)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Uses DataAnnotationValidateOptions which is unsafe given that the options type passed in when calling Validate cannot be statically analyzed so its members may be trimmed.

Check warning on line 27 in src/ResxTranslator/Bit.ResxTranslator/Program.cs

View workflow job for this annotation

GitHub Actions / build Bit.ResxTranslator 

Using member 'Microsoft.Extensions.DependencyInjection.OptionsBuilderConfigurationExtensions.Bind<TOptions>(OptionsBuilder<TOptions>, IConfiguration)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. Binding strongly typed objects to configuration values may require generating dynamic code at runtime.

Check warning on line 27 in src/ResxTranslator/Bit.ResxTranslator/Program.cs

View workflow job for this annotation

GitHub Actions / build Bit.ResxTranslator 

Using member 'Microsoft.Extensions.DependencyInjection.OptionsBuilderConfigurationExtensions.Bind<TOptions>(OptionsBuilder<TOptions>, IConfiguration)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. TOptions's dependent types may have their members trimmed. Ensure all required members are preserved.
.Bind(configuration)
.ValidateDataAnnotations()
.ValidateOnStart();

ResxTranslatorSettings settings = new();
configuration.Bind(settings);

Check warning on line 33 in src/ResxTranslator/Bit.ResxTranslator/Program.cs

View workflow job for this annotation

GitHub Actions / build Bit.ResxTranslator 

Using member 'Microsoft.Extensions.Configuration.ConfigurationBinder.Bind(IConfiguration, Object)' which has 'RequiresDynamicCodeAttribute' can break functionality when AOT compiling. Binding strongly typed objects to configuration values requires generating dynamic code at runtime, for example instantiating generic types.

Check warning on line 33 in src/ResxTranslator/Bit.ResxTranslator/Program.cs

View workflow job for this annotation

GitHub Actions / build Bit.ResxTranslator 

Using member 'Microsoft.Extensions.Configuration.ConfigurationBinder.Bind(IConfiguration, Object)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Cannot statically analyze the type of instance so its members may be trimmed.
services.AddSingleton(settings);

services.AddLogging(loggingBuilder =>
{
loggingBuilder.AddConfiguration(configuration.GetSection("Logging"));
loggingBuilder.AddConsole();
});

Expand Down
Loading