Apply more features of the C# 14 on bit Boilerplate (#11588)

[ysmoradi]

closes #11588

Summary by CodeRabbit

• Refactor

  • Simplified validation logic with modern null-handling patterns.
  • Improved disposal handling efficiency.
  • Streamlined telemetry service implementation.

• Chores

  • Updated project configuration and cleaned up diagnostic settings.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

These changes modernize the boilerplate codebase to leverage contemporary C# language features, replacing explicit null-check blocks with null-conditional operators and simplifying property backing field patterns. Four files across client core, MAUI, and web projects are updated accordingly.

Changes

Cohort / File(s)	Summary
Null-conditional operator simplification src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/AppDataAnnotationsValidator.cs, src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Maui/Services/MauiDeviceCoordinator.cs	Replaces explicit null-check blocks with null-conditional assignments (?. operator) and null-coalescing assignments (??=). Simplifies DisposeAsync logic in AppDataAnnotationsValidator with null-conditional unsubscribe.
Implicit backing field modernization src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Services/Contracts/ITelemetryContext.cs	Removes explicit private static backing field _current from ITelemetryContext interface. Updates Current property accessors to use implicit backing field pattern (field keyword).
Project configuration update src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/Boilerplate.Client.Web.csproj	Introduces BOM character at file start. Adds commented-out Blazor WebAssembly diagnostics PropertyGroup block with diagnostic-related settings.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Heterogeneous changes: Modifications span different patterns (null-conditional operators, implicit backing fields, project configuration) requiring separate reasoning for each file.
• Focus areas for review:
  • Verify null-conditional assignments in AppDataAnnotationsValidator and MauiDeviceCoordinator maintain identical behavior to previous explicit checks
  • Confirm implicit backing field usage in ITelemetryContext (C# 14 feature) is correctly applied and thread-safe
  • Assess whether BOM character in .csproj is intentional or introduced accidentally

Poem

🐰 Null-conditionals and implicit fields take the stage,
C# fourteen brings us to a modern age,
Shorter syntax, cleaner code, oh what a sight!
The boilerplate now dances in the light!
✨ Hop along, dear developers, modernize with might!

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 03c662e and fcf05a4.

📒 Files selected for processing (4)

• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/AppDataAnnotationsValidator.cs (6 hunks)
• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Services/Contracts/ITelemetryContext.cs (1 hunks)
• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Maui/Services/MauiDeviceCoordinator.cs (1 hunks)
• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/Boilerplate.Client.Web.csproj (2 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}