-
-
Notifications
You must be signed in to change notification settings - Fork 254
Use projects relative paths for aspire (#11508) #11509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughUpdated project registrations in the AppHost Program.cs from generic type-based API calls to explicit relative csproj path-based registrations for four projects (serverweb, serverapi, clientwebwasm, clientwindows) to support aspire configuration requirements. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the .NET Aspire project references from using the generic AddProject<T>() method with compile-time generated project types to using the explicit AddProject(string, string) overload with hardcoded project paths. This change eliminates the need for the Projects namespace and removes the requirement to replace dots with underscores in project type names.
- Replaced all four
AddProject<T>()calls withAddProject(name, path)calls - Updated project paths to use relative paths from the AppHost directory
- Removed the need for workaround comments about replacing dots with underscores
Comments suppressed due to low confidence (1)
src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Program.cs:2
- The
using Projects;directive is no longer used after migrating to explicit project path references. This unused import should be removed.
using Projects;
closes #11508
Summary by CodeRabbit