Skip to content

Conversation

@ysmoradi
Copy link
Member

@ysmoradi ysmoradi commented Oct 29, 2025

closes #11508

Summary by CodeRabbit

  • Chores
    • Updated project registration configuration to use explicit file paths instead of generic type-based references for improved build consistency.

@ysmoradi ysmoradi requested a review from Copilot October 29, 2025 15:05
@coderabbitai
Copy link

coderabbitai bot commented Oct 29, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Updated project registrations in the AppHost Program.cs from generic type-based API calls to explicit relative csproj path-based registrations for four projects (serverweb, serverapi, clientwebwasm, clientwindows) to support aspire configuration requirements.

Changes

Cohort / File(s) Change Summary
AppHost Project Registration Migration
src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Program.cs
Replaced four generic AddProject<T>(name) calls with explicit path-based AddProject(name, csprojPath) registrations: serverweb, serverapi, clientwebwasm, and clientwindows projects now use explicit relative paths to their .csproj files instead of type-based resolution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A hop through the aspire we take,
With paths explicit for config's sake,
Four projects aligned in perfect view,
Boilerplate paths renewed and true! 🌟

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Use projects relative paths for aspire (#11508)" directly and accurately summarizes the main change in the changeset. The raw summary confirms that the code replaces generic type-based project registrations (AddProject()) with explicit csproj-path-based registrations (AddProject(name, path)) across multiple project registrations in the Program.cs file. The title is concise, clear, and specific enough for reviewers scanning the history to quickly understand the primary change.
Linked Issues Check ✅ Passed The linked issue #11508 requires the boilerplate to use projects-relative paths for aspire, and the code changes directly fulfill this requirement. The raw summary shows that all four project registrations (serverweb, serverapi, clientwebwasm, clientwindows) have been converted from generic type-based registration to explicit csproj-path-based registration, with each using a relative path to its respective project file. The changes in Program.cs are solely focused on this conversion pattern, with surrounding fluent calls preserved and only the project specification method signature changing from AddProject(string) to AddProject(string, string).
Out of Scope Changes Check ✅ Passed All changes in this pull request are directly related to the linked issue requirement to use projects-relative paths for aspire. The modifications are confined to the Program.cs file, converting four project registrations from generic type-based to explicit path-based registration methods. The removal of sample comments is a minor, incidental change directly tied to the method signature update and does not introduce any out-of-scope functionality or unrelated modifications.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the .NET Aspire project references from using the generic AddProject<T>() method with compile-time generated project types to using the explicit AddProject(string, string) overload with hardcoded project paths. This change eliminates the need for the Projects namespace and removes the requirement to replace dots with underscores in project type names.

  • Replaced all four AddProject<T>() calls with AddProject(name, path) calls
  • Updated project paths to use relative paths from the AppHost directory
  • Removed the need for workaround comments about replacing dots with underscores
Comments suppressed due to low confidence (1)

src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Program.cs:2

  • The using Projects; directive is no longer used after migrating to explicit project path references. This unused import should be removed.
using Projects;

@ysmoradi ysmoradi merged commit cc68567 into bitfoundation:develop Oct 29, 2025
3 checks passed
@ysmoradi ysmoradi deleted the 11508 branch October 29, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bit Boilerplate must use projects relative paths for aspire

1 participant