Skip to content

Conversation

@ysmoradi
Copy link
Member

@ysmoradi ysmoradi commented Oct 12, 2025

closes #11474

Summary by CodeRabbit

  • Chores

    • Streamlined CI: target specific test projects, simplified test commands, added post-test cleanup, and updated environment variables.
    • Configured a default .NET test runner.
    • Removed an optional editor extension from the development container.
  • Tests

    • Migrated test infrastructure to a new test SDK and adjusted exception assertions; no behavioral changes.
  • Demo

    • Updated third-party dependencies in server and Windows client demos to latest patch versions.

@coderabbitai
Copy link

coderabbitai bot commented Oct 12, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This change updates CI workflows, test configuration, and dependencies. It specifies project paths in tests, renames an environment variable, simplifies test invocations, adds a cleanup step, configures a new test runner, refactors the test project SDK and packages, adjusts some test assertions, removes a devcontainer extension, and bumps two package versions.

Changes

Cohort / File(s) Summary
Devcontainer tooling
\.devcontainer/devcontainer.json
Removed DominicVonk.vscode-resx-editor from VS Code extensions.
CI workflows
\.github/workflows/bit.ci.yml, \.github/workflows/bit.full.ci.yml
bit.ci: added explicit --project to dotnet test steps targeting Bit.BlazorUI.Tests. bit.full.ci: renamed env var ConnectionStrings__SqlServerConnectionStringConnectionStrings__sqldb, simplified dotnet test invocations, and added cleanup to remove SimpleTest and TestSqlServer directories.
Test runner and project setup
dotnet.config, src/BlazorUI/Bit.BlazorUI.Tests/Bit.BlazorUI.Tests.csproj
Added [dotnet.test.runner] name=Microsoft.Testing.Platform. Switched test project to MSTest.Sdk/4.0.0 SDK with Microsoft.NET.Sdk.Razor, enabled RollForward=Major, and removed Microsoft.NET.Test.Sdk, MSTest.TestAdapter, MSTest.TestFramework, coverlet.collector. Kept bunit.web.
Test assertion API adjustments
src/BlazorUI/Bit.BlazorUI.Tests/Components/Inputs/ColorPicker/BitColorPickerTests.cs, .../Utilities/Link/BitLinkTests.cs
Changed exception assertions from generic ThrowsException<T>/Throws<T> to non-generic variants expecting the same exception types.
No functional test diffs
.../Inputs/Dropdown/BitDropdownTests.cs, .../Inputs/NumberField/BitNumberFieldTests.cs, .../Navs/Nav/BitNavTests.cs, .../Progress/ProgressBar/BitProgressTests.cs
Modified lines are effectively no-ops; behavior unchanged.
Demo dependency bumps
src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj, src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj
Updated ModelContextProtocol to 0.4.0-preview.2. Updated Microsoft.Web.WebView2 to 1.0.3537.50.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

I tidied my burrow of tests today,
Swapped my SDK, hopped CI’s way.
Pruned an extension, packed light for the run,
Set paths for dotnet, when sprints are begun.
With versions refreshed and crumbs swept clean,
This rabbit commits—swift, crisp, serene. 🐇✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 379cf3d and e151a60.

📒 Files selected for processing (13)
  • .devcontainer/devcontainer.json (0 hunks)
  • .github/workflows/bit.ci.yml (2 hunks)
  • .github/workflows/bit.full.ci.yml (4 hunks)
  • dotnet.config (1 hunks)
  • src/BlazorUI/Bit.BlazorUI.Tests/Bit.BlazorUI.Tests.csproj (1 hunks)
  • src/BlazorUI/Bit.BlazorUI.Tests/Components/Inputs/ColorPicker/BitColorPickerTests.cs (1 hunks)
  • src/BlazorUI/Bit.BlazorUI.Tests/Components/Inputs/Dropdown/BitDropdownTests.cs (5 hunks)
  • src/BlazorUI/Bit.BlazorUI.Tests/Components/Inputs/NumberField/BitNumberFieldTests.cs (1 hunks)
  • src/BlazorUI/Bit.BlazorUI.Tests/Components/Navs/Nav/BitNavTests.cs (2 hunks)
  • src/BlazorUI/Bit.BlazorUI.Tests/Components/Progress/ProgressBar/BitProgressTests.cs (3 hunks)
  • src/BlazorUI/Bit.BlazorUI.Tests/Components/Utilities/Link/BitLinkTests.cs (1 hunks)
  • src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ysmoradi ysmoradi merged commit ff89d24 into bitfoundation:develop Oct 12, 2025
2 of 3 checks passed
@ysmoradi ysmoradi deleted the 11474 branch October 12, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Project dependencies are outdated

1 participant