-
-
Notifications
You must be signed in to change notification settings - Fork 254
Update bit boilerplate to aspire 9.5, add dev tunnels (#11442) #11445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughDependency versions were updated across Aspire packages and ServiceDiscovery. The AppHost project added Aspire.Hosting.DevTunnels and bumped Aspire.AppHost.Sdk. Program.cs updated the pgvector image tag and introduced conditional development tunnels for API and Web under run mode, wiring endpoints when applicable. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer
participant AppHost as AppHost (Program.cs)
participant API as Server API Project
participant Web as Server Web Project
participant DevTunnel as Dev Tunnels
Dev->>AppHost: Start in run mode
rect rgba(200,230,255,0.25)
note right of AppHost: Configure containers<br/>- Set pgvector image tag: pgvector:pg18
end
alt Standalone API enabled (conditional)
AppHost->>DevTunnel: Create API dev tunnel (anonymous)
AppHost->>API: Wire endpoint -> devTunnel
else Other modes or disabled
AppHost--xDevTunnel: Skip API tunnel
end
AppHost->>DevTunnel: Create Web dev tunnel (anonymous)
AppHost->>Web: Wire endpoint -> devTunnel
AppHost-->>Dev: AppHost ready with configured tunnels
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the bit boilerplate template to use Aspire 9.5 and adds DevTunnels support for external access to development environments.
- Updates Aspire dependencies from version 9.4.2 to 9.5.0
- Adds DevTunnel configuration for both API and web projects with anonymous access
- Updates PostgreSQL container image from pg17 to pg18
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Program.cs | Updates PostgreSQL image version and adds DevTunnel configuration for API and web projects |
| Boilerplate.Server.AppHost.csproj | Updates Aspire SDK version and adds DevTunnels package reference |
| Directory.Packages.props | Updates all Aspire package versions to 9.5.0 and adds DevTunnels package version |
src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Program.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Program.cs (1)
124-126: Drop the unusedvar tunnelassignment.The result of
AddDevTunnel(...)isn’t stored or reused, so keeping the local just introduces an unused-variable warning. You can return to the fluent chain directly.- var tunnel = builder.AddDevTunnel("web-dev-tunnel") - .WithAnonymousAccess() - .WithReference(serverWebProject.WithHttpEndpoint(name: "devTunnel").GetEndpoint("devTunnel")); + builder.AddDevTunnel("web-dev-tunnel") + .WithAnonymousAccess() + .WithReference(serverWebProject.WithHttpEndpoint(name: "devTunnel").GetEndpoint("devTunnel"));
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (3)
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props(2 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Boilerplate.Server.AppHost.csproj(2 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Program.cs(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build and test
🔇 Additional comments (3)
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props (2)
6-6: Central version for DevTunnels looks good.Line 6 now centrally tracks
Aspire.Hosting.DevTunnels, so the AppHost reference will pick up the intended preview build from one spot. LGTM.
54-59: Aspire hosting stack bumped consistently.Lines 54-59 and 62 move the Aspire hosting packages and ServiceDiscovery to 9.5.0, matching the AppHost SDK upgrade and preventing version skew. Looks good.
Also applies to: 62-62
src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Boilerplate.Server.AppHost.csproj (1)
3-3: AppHost SDK and DevTunnels reference aligned.Updating the SDK to 9.5.0 and adding the DevTunnels package (fed by the new central version) keeps the host project consistent with the template dependencies. LGTM.
Also applies to: 15-15
cloes #11442
Summary by CodeRabbit
New Features
Chores