Skip to content

Conversation

@ysmoradi
Copy link
Member

@ysmoradi ysmoradi commented Sep 26, 2025

cloes #11442

Summary by CodeRabbit

  • New Features

    • Added development tunnels for API and Web apps in local run mode, enabling easy external access for testing and demos.
  • Chores

    • Upgraded platform dependencies to the 9.5.0 release line for improved stability and compatibility.
    • Added the Dev Tunnels dependency to support new local tunneling capabilities.
    • Updated the PostgreSQL vector extension to pg18 for better performance and compatibility.

@ysmoradi ysmoradi requested review from Copilot and msynk September 26, 2025 17:52
@coderabbitai
Copy link

coderabbitai bot commented Sep 26, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Dependency versions were updated across Aspire packages and ServiceDiscovery. The AppHost project added Aspire.Hosting.DevTunnels and bumped Aspire.AppHost.Sdk. Program.cs updated the pgvector image tag and introduced conditional development tunnels for API and Web under run mode, wiring endpoints when applicable.

Changes

Cohort / File(s) Summary
Central package versions
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props
Added Aspire.Hosting.DevTunnels 9.5.0-preview.1.25474.7. Bumped versions to 9.5.0 for Aspire.Hosting.AppHost, Aspire.Hosting.SqlServer, Aspire.Hosting.PostgreSQL, Aspire.Hosting.MySql, Aspire.Hosting.Azure.Storage, and Microsoft.Extensions.ServiceDiscovery.
AppHost project configuration
src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Boilerplate.Server.AppHost.csproj
Upgraded Aspire.AppHost.Sdk 9.4.2 → 9.5.0. Added Aspire.Hosting.DevTunnels reference.
AppHost runtime logic
src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Program.cs
Switched pgvector image tag pgvector:pg17pgvector:pg18. Added run-mode-gated dev tunnel setup: API dev tunnel (conditionally compiled) and Web dev tunnel with anonymous access, wiring to respective endpoints.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Dev as Developer
    participant AppHost as AppHost (Program.cs)
    participant API as Server API Project
    participant Web as Server Web Project
    participant DevTunnel as Dev Tunnels

    Dev->>AppHost: Start in run mode
    rect rgba(200,230,255,0.25)
    note right of AppHost: Configure containers<br/>- Set pgvector image tag: pgvector:pg18
    end

    alt Standalone API enabled (conditional)
        AppHost->>DevTunnel: Create API dev tunnel (anonymous)
        AppHost->>API: Wire endpoint -> devTunnel
    else Other modes or disabled
        AppHost--xDevTunnel: Skip API tunnel
    end

    AppHost->>DevTunnel: Create Web dev tunnel (anonymous)
    AppHost->>Web: Wire endpoint -> devTunnel

    AppHost-->>Dev: AppHost ready with configured tunnels
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

I thump my paws on verdant ground,
New tunnels hum, a whiskered sound—
Vectors bumped from 17 to 18 bright,
AppHost shines in updated light.
With version hops and ports anew,
I nibble docs and test the view.
Hippity-hop—ship this through! 🐇🚀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly conveys the primary changes by specifying the upgrade of the Bit boilerplate to Aspire 9.5 and the addition of development tunnels, matching the content of the pull request.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the bit boilerplate template to use Aspire 9.5 and adds DevTunnels support for external access to development environments.

  • Updates Aspire dependencies from version 9.4.2 to 9.5.0
  • Adds DevTunnel configuration for both API and web projects with anonymous access
  • Updates PostgreSQL container image from pg17 to pg18

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
Program.cs Updates PostgreSQL image version and adds DevTunnel configuration for API and web projects
Boilerplate.Server.AppHost.csproj Updates Aspire SDK version and adds DevTunnels package reference
Directory.Packages.props Updates all Aspire package versions to 9.5.0 and adds DevTunnels package version

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Program.cs (1)

124-126: Drop the unused var tunnel assignment.

The result of AddDevTunnel(...) isn’t stored or reused, so keeping the local just introduces an unused-variable warning. You can return to the fluent chain directly.

-    var tunnel = builder.AddDevTunnel("web-dev-tunnel")
-        .WithAnonymousAccess()
-        .WithReference(serverWebProject.WithHttpEndpoint(name: "devTunnel").GetEndpoint("devTunnel"));
+    builder.AddDevTunnel("web-dev-tunnel")
+        .WithAnonymousAccess()
+        .WithReference(serverWebProject.WithHttpEndpoint(name: "devTunnel").GetEndpoint("devTunnel"));
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between c388813 and 28fa543.

📒 Files selected for processing (3)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props (2 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Boilerplate.Server.AppHost.csproj (2 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Program.cs (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build and test
🔇 Additional comments (3)
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props (2)

6-6: Central version for DevTunnels looks good.

Line 6 now centrally tracks Aspire.Hosting.DevTunnels, so the AppHost reference will pick up the intended preview build from one spot. LGTM.


54-59: Aspire hosting stack bumped consistently.

Lines 54-59 and 62 move the Aspire hosting packages and ServiceDiscovery to 9.5.0, matching the AppHost SDK upgrade and preventing version skew. Looks good.

Also applies to: 62-62

src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Boilerplate.Server.AppHost.csproj (1)

3-3: AppHost SDK and DevTunnels reference aligned.

Updating the SDK to 9.5.0 and adding the DevTunnels package (fed by the new central version) keeps the host project consistent with the template dependencies. LGTM.

Also applies to: 15-15

@ysmoradi ysmoradi merged commit 11fc24a into bitfoundation:develop Sep 26, 2025
3 checks passed
@ysmoradi ysmoradi deleted the 11442 branch September 26, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant