Skip to content

Conversation

@ysmoradi
Copy link
Member

@ysmoradi ysmoradi commented Sep 25, 2025

closes #11437

Summary by CodeRabbit

  • Chores
    • Updated Blazor WebAssembly globalization configuration to load all globalization data when Invariant Globalization is disabled. This enhances localization coverage and consistency for dates, numbers, currencies, and text collation across supported locales. No other functional behavior is affected.
  • Refactor
    • Aligned project settings with the latest globalization option naming for better maintainability and forward compatibility.

@coderabbitai
Copy link

coderabbitai bot commented Sep 25, 2025

Walkthrough

Replaced the MSBuild property HybridGlobalization with BlazorWebAssemblyLoadAllGlobalizationData in the Blazor WebAssembly client project file, retaining the existing condition that applies when InvariantGlobalization is false.

Changes

Cohort / File(s) Change Summary
Globalization configuration property update
src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/Boilerplate.Client.Web.csproj
Replaced HybridGlobalization with BlazorWebAssemblyLoadAllGlobalizationData under the same condition Condition="'$(InvariantGlobalization)' == 'false'".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I nudge a switch with whiskered grace,
From Hybrid paths to Blazor’s place.
When invariants don’t hold the line,
Load all the cultures, crisp and fine.
Thump-thump—configurations set,
A tidy hop, no sweat! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly summarizes the key change of replacing the HybridGlobalization property with BlazorWebAssemblyLoadAllGlobalizationData in the boilerplate project, directly reflecting the pull request content without ambiguity.
Linked Issues Check ✅ Passed The changes directly implement the linked issue’s requirement by removing the HybridGlobalization property and introducing BlazorWebAssemblyLoadAllGlobalizationData under the same conditional logic in the boilerplate project file, fully satisfying the specified objective.
Out of Scope Changes Check ✅ Passed Only the targeted MSBuild property name was updated with no additional modifications beyond the scope of replacing HybridGlobalization with BlazorWebAssemblyLoadAllGlobalizationData, so there are no unrelated changes present.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 4d01c9b and bae863a.

📒 Files selected for processing (1)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/Boilerplate.Client.Web.csproj (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build and test
🔇 Additional comments (1)
src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/Boilerplate.Client.Web.csproj (1)

9-9: Change adopts the new globalization property correctly.

Switching to BlazorWebAssemblyLoadAllGlobalizationData under the existing condition lines up with the updated Blazor WebAssembly guidance. Nicely done.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ysmoradi ysmoradi merged commit b1a9b9b into bitfoundation:develop Sep 25, 2025
2 of 3 checks passed
@ysmoradi ysmoradi deleted the 11437 branch September 25, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HybridGlobalization has to be replaced BlazorWebAssemblyLoadAllGlobalizationData in bit Boilerplate

1 participant