-
-
Notifications
You must be signed in to change notification settings - Fork 254
Update cache busting section of getting started page in BlazorUI demo (#11336) #11337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cache busting section of getting started page in BlazorUI demo (#11336) #11337
Conversation
WalkthroughAdds an “Optional components” section to GettingStartedPage.razor describing Automatic Resource Fingerprinting via Bit.BlazorUI.Assets, including script/link fingerprinting examples and a reference note. Also fixes a typo (“resrouce” → “resource”). No functional or API changes. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesPoem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/GettingStartedPage.razor (4)
140-147: Clarify namespace/import so Script/Link compile out of the box.If these components live under a different namespace than Bit.BlazorUI, mention the required import (e.g., @using Bit.BlazorUI.Assets) here or in step 2 to prevent “component not found” build errors.
Proposed inline note:
standalone components designed for automatic resource fingerprinting in the <BitTag Color="BitColor.TertiaryBackground">App.razor</BitTag> file: </BitText> + <BitText Typography="BitTypography.Body2"> + <b>Note</b>: Ensure the namespace import for these components is available (e.g., + <BitTag Color="BitColor.TertiaryBackground">@using Bit.BlazorUI.Assets</BitTag>). + </BitText>
164-167: Use the correct lowercase HTML tag name in the narrative.HTML uses , not .
- <b>Link</b>: A direct replacement for the standard HTML <BitTag Color="BitColor.TertiaryBackground"><Link></BitTag> tag. + <b>Link</b>: A direct replacement for the standard HTML <BitTag Color="BitColor.TertiaryBackground"><link></BitTag> tag.
172-172: Fix HTML entity to render the example correctly.Missing semicolon after < causes the literal “<link” to render instead of “”.
- <CodeBox><link href="_content/Bit.BlazorUI/styles/bit.blazorui.css?v=sha256-VI6BIGZLTtmyhn3V-4RH-Yyi0Ud3p0g5dHvByeaoZ9Y" rel="stylesheet"></CodeBox> + <CodeBox><link href="_content/Bit.BlazorUI/styles/bit.blazorui.css?v=sha256-VI6BIGZLTtmyhn3V-4RH-Yyi0Ud3p0g5dHvByeaoZ9Y" rel="stylesheet"></CodeBox>
176-181: Minor grammar improvement.“checkout” → “check out”.
- <b>Note</b>: You can checkout the usages of these two components in our demo website project + <b>Note</b>: You can check out the usages of these two components in our demo website project
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting
📒 Files selected for processing (1)
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/GettingStartedPage.razor(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build and test
🔇 Additional comments (1)
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/GettingStartedPage.razor (1)
135-135: Typo fix LGTM.“resource URLs” correction reads well.
closes #11336
Summary by CodeRabbit
Documentation
Bug Fixes