Delete Link and Script components across projects (#11324) #11325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughUpdates dependency versions. Modifies HTTP request header handling to conditionally add/remove headers based on internal vs external requests. Expands CORS exposed headers. Removes custom Link and Script Blazor components and their code-behinds. Removes MVC service registration from Server.Web. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Client as Client App
participant Handler as RequestHeadersDelegatingHandler
participant Server as Server API
Note over Client,Server: Request flow with conditional headers
User->>Client: Trigger HTTP request
Client->>Handler: SendAsync(request)
alt Internal request
Note right of Handler: Add X-App-Version, X-App-Platform
else External request
Note right of Handler: Remove X-Origin
end
Handler->>Server: Forward request
Server-->>Handler: Response (CORS exposes RequestId, Age, App-Cache-Response,<br/>X-App-Platform, X-App-Version, X-Origin)
Handler-->>Client: Return response
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependencies in the bit Boilerplate template and removes custom Script and Link components in favor of simpler implementations. The changes include updating various NuGet package versions and adding additional CORS headers for better API integration.
- Updates multiple NuGet package versions to their latest stable releases
- Removes custom Script and Link Blazor components that handled file versioning
- Adds new CORS exposed headers for better API client integration
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Directory.Packages.props | Updates package versions for Fido2, libphonenumber, CommunityToolkit.Aspire, Magick.NET, Microsoft.Identity.Web, and Twilio |
| Program.Services.cs (Server.Api) | Adds additional CORS exposed headers for API metadata |
| Program.Services.cs (Server.Web) | Removes MVC service registration |
| Script.razor/.cs | Removes custom Script component with file versioning |
| Link.razor/.cs | Removes custom Link component with file versioning |
| RequestHeadersDelegatingHandler.cs | Adds conditional header logic for internal vs external API requests |
...ient/Boilerplate.Client.Core/Services/HttpMessageHandlers/RequestHeadersDelegatingHandler.cs
Outdated
Show resolved
Hide resolved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Services/HttpMessageHandlers/RequestHeadersDelegatingHandler.cs (1)
28-37: Centralize custom header names to avoid typos.Define shared constants (e.g., AppHeaders.XAppVersion, etc.) used by both client and server.
I can add an AppHeaders static class and update usages across projects.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting
📒 Files selected for processing (8)
src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Services/HttpMessageHandlers/RequestHeadersDelegatingHandler.cs(1 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props(4 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Program.Services.cs(1 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Web/Components/Link.razor(0 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Web/Components/Link.razor.cs(0 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Web/Components/Script.razor(0 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Web/Components/Script.razor.cs(0 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Web/Program.Services.cs(0 hunks)
💤 Files with no reviewable changes (5)
- src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Web/Components/Script.razor
- src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Web/Program.Services.cs
- src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Web/Components/Script.razor.cs
- src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Web/Components/Link.razor
- src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Web/Components/Link.razor.cs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build blazor hybrid (windows)
- GitHub Check: build api + blazor web
- GitHub Check: build and test
🔇 Additional comments (2)
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props (2)
16-16: Deps bump LGTM.libphonenumber-csharp, Magick.NET, Microsoft.Identity.Web, and Twilio updates look good.
Also applies to: 99-99, 110-110, 117-117
55-55: No config changes needed for Aspire toolkit 9.7.2 bump. Release notes only include documentation fixes, API surface updates, and new optional features—no breaking or config changes introduced.
...ient/Boilerplate.Client.Core/Services/HttpMessageHandlers/RequestHeadersDelegatingHandler.cs
Show resolved
Hide resolved
src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Program.Services.cs
Show resolved
Hide resolved
…te.Client.Core/Services/HttpMessageHandlers/RequestHeadersDelegatingHandler.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Yaser Moradi <ysmoradi@outlook.com>
ysmoradi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11324
Summary by CodeRabbit