Skip to content

Conversation

@ysmoradi
Copy link
Member

@ysmoradi ysmoradi commented Aug 18, 2025

closes #11282

Summary by CodeRabbit

  • Bug Fixes
    • Corrected handling of rate-limit errors across authentication flows (sign-in, sign-up, password reset, email/phone confirmation, OTP), ensuring users see accurate “Too many requests” messages instead of generic errors.
    • Improved consistency and reliability of throttling feedback when resending verification or reset tokens, reducing confusion and preventing missed notifications.
    • Aligned localized messages for “Too many requests” to display properly across supported languages.

@coderabbitai
Copy link

coderabbitai bot commented Aug 18, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Renames the custom exception from TooManyRequestsExceptions to TooManyRequestsException across client and server code, adds the new exception class, removes the old one, updates catches/throws accordingly, and renames the related localization resource keys in both default and Farsi .resx files.

Changes

Cohort / File(s) Summary of Edits
Client: Identity error handling
.../Client/Boilerplate.Client.Core/Components/Pages/Identity/ForgotPasswordPage.razor.cs, .../Client/Boilerplate.Client.Core/Components/Pages/Identity/SignIn/SignInPanel.razor.cs, .../Client/Boilerplate.Client.Core/Components/Pages/Identity/SignUp/SignUpPage.razor.cs, .../Client/Boilerplate.Client.Core/Services/AuthManager.cs
Updated catch clauses to use TooManyRequestsException instead of TooManyRequestsExceptions.
Server: Identity controllers
.../Server/Boilerplate.Server.Api/Controllers/Identity/IdentityController.cs, .../Controllers/Identity/IdentityController.EmailConfirmation.cs, .../Controllers/Identity/IdentityController.PhoneConfirmation.cs, .../Controllers/Identity/IdentityController.ResetPassword.cs, .../Controllers/Identity/UserController.cs
Replaced thrown/caught type TooManyRequestsExceptions with TooManyRequestsException in sign-in, OTP/two-factor, email/phone confirmation, reset password, change email/phone, and elevated access token flows.
Shared: Exception types
.../Shared/Exceptions/TooManyRequestsException.cs, .../Shared/Exceptions/TooManyRequestsExceptions.cs
Added TooManyRequestsException (singular) with constructors and status code override; removed TooManyRequestsExceptions (plural).
Localization resources
.../Shared/Resources/AppStrings.resx, .../Shared/Resources/AppStrings.fa.resx
Renamed resource key from TooManyRequestsExceptions to TooManyRequestExceptions; values unchanged.

Sequence Diagram(s)

sequenceDiagram
  actor User
  participant Client as Client (UI)
  participant Server as Server API
  participant Loc as Localization
  participant Exc as TooManyRequestsException

  User->>Client: Request OTP/Sign In/Reset/Confirm
  Client->>Server: Send request
  Server->>Server: Check resend rate limit
  alt Rate limited
    Server->>Loc: Get "TooManyRequestExceptions" message
    Server->>Exc: throw TooManyRequestsException
    Server-->>Client: 429 TooManyRequests
    Client->>Client: catch TooManyRequestsException
    Client->>User: Show error (Snackbar)
  else Allowed
    Server-->>Client: Success
    Client->>User: Proceed
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Assessment against linked issues

Objective Addressed Explanation
Fix typo in TooManyRequestsException across boilerplate (#11282)

Assessment against linked issues: Out-of-scope changes

Code Change Explanation
Rename of resource key to TooManyRequestExceptions (singular “Request”) in .../Shared/Resources/AppStrings.resx and AppStrings.fa.resx Issue mentions the exception type typo; it’s unclear if the resource key was intended to be singular “Request” vs. “Requests”. This may be an additional rename not explicitly stated.

Poem

I thump my paws: the typo’s gone, hooray!
From plural peaks to singular we hop today.
Exceptions aligned, the rate limits make sense,
Resx whispers match in every tense.
With snacks and 429s we’re set—
A tidy warren, no regrets! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 30500c9 and e6c88b4.

📒 Files selected for processing (13)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/ForgotPasswordPage.razor.cs (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/SignIn/SignInPanel.razor.cs (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/SignUp/SignUpPage.razor.cs (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Services/AuthManager.cs (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Controllers/Identity/IdentityController.EmailConfirmation.cs (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Controllers/Identity/IdentityController.PhoneConfirmation.cs (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Controllers/Identity/IdentityController.ResetPassword.cs (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Controllers/Identity/IdentityController.cs (3 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Controllers/Identity/UserController.cs (3 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Exceptions/TooManyRequestsException.cs (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Exceptions/TooManyRequestsExceptions.cs (0 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Resources/AppStrings.fa.resx (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Resources/AppStrings.resx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ysmoradi ysmoradi merged commit 1a62269 into bitfoundation:develop Aug 18, 2025
1 of 3 checks passed
@ysmoradi ysmoradi deleted the 11282 branch August 18, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in bit Boilerplate TooManyRequestsException

1 participant