-
-
Notifications
You must be signed in to change notification settings - Fork 254
Preserve dotnet new bit-bp parameters while creating project for further references (#11252) #11253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA detailed example command with conditional flags was added to the Bit.Boilerplate template's README.md to illustrate project generation options. Additionally, an XML comment indicating the template version was removed from Directory.Build.props. No code logic or public entity declarations were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/Templates/Boilerplate/Bit.Boilerplate/README.md (2)
62-64: Boolean parameter is shown only for the false case – may be misleadingEvery other boolean flag (
aspire,notification,sample, …) is listed when its value istrue.
cloudflareis the single exception (--cloudflare false). If the intent is to demonstrate turning it on, mirror the pattern used above; if the intent is to demonstrate that it can be disabled, add a short inline comment to avoid confusion.
7-68: Consider collapsing the long conditional command for readabilityThe exhaustive list of
--flagpermutations is useful for template authors but may overwhelm end-users skimming the README. A shorter example plus a link to full docs (or a collapsible<details>block) keeps the file concise while still exposing the information.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting
📒 Files selected for processing (2)
src/Templates/Boilerplate/Bit.Boilerplate/README.md(2 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props(0 hunks)
💤 Files with no reviewable changes (1)
- src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build and test
closes #11252
Summary by CodeRabbit