-
-
Notifications
You must be signed in to change notification settings - Fork 254
Improve msbuild task to remove residual .razor.css.map files (#11051) #11052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve msbuild task to remove residual .razor.css.map files (#11051) #11052
Conversation
WalkthroughThe MSBuild target for cleaning up orphaned scoped CSS files in Blazor projects was updated: its name and related variables were changed, the file pattern now includes both Changes
Sequence Diagram(s)sequenceDiagram
participant MSBuild
participant Directory.Build.props
participant FileSystem
MSBuild->>Directory.Build.props: Start build
Directory.Build.props->>FileSystem: Identify *.razor.css and *.razor.css.map files without matching .razor file
Directory.Build.props->>FileSystem: Delete identified residual files
Directory.Build.props->>MSBuild: Continue with ComputeCssScope
Assessment against linked issues
Poem
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props (1)
92-92: Consider forward-slash globs for cross-platform consistency
"**\*.razor.css*"works, but MSBuild treats/and\differently on some hosts (especially when globbing via bash). Prefer**/*.razor.css*to avoid escaping and remain OS-agnostic.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting
📒 Files selected for processing (1)
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build and test
🔇 Additional comments (1)
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props (1)
81-89: Great clarification in XML-doc commentsThe expanded comment succinctly explains the orphan-file scenario and why the target must run early. It will save future maintainers time.
closes #11051
Summary by CodeRabbit