Skip to content

Conversation

@msynk
Copy link
Member

@msynk msynk commented Jul 4, 2025

closes #11051

Summary by CodeRabbit

  • Chores
    • Improved handling of residual scoped CSS files in Blazor projects to ensure all related files (including map files) are properly cleaned up during the build process.
    • Enhanced documentation within the build configuration for better clarity.

@msynk msynk requested a review from ysmoradi July 4, 2025 04:29
@coderabbitai
Copy link

coderabbitai bot commented Jul 4, 2025

Walkthrough

The MSBuild target for cleaning up orphaned scoped CSS files in Blazor projects was updated: its name and related variables were changed, the file pattern now includes both .razor.css and .razor.css.map files, and comments were clarified. The logic for identifying and deleting residual files remains the same.

Changes

File(s) Change Summary
src/Templates/Boilerplate/Bit.Boilerplate/...props Renamed MSBuild target and variables; expanded file pattern to include .razor.css* files; improved comments.

Sequence Diagram(s)

sequenceDiagram
    participant MSBuild
    participant Directory.Build.props
    participant FileSystem

    MSBuild->>Directory.Build.props: Start build
    Directory.Build.props->>FileSystem: Identify *.razor.css and *.razor.css.map files without matching .razor file
    Directory.Build.props->>FileSystem: Delete identified residual files
    Directory.Build.props->>MSBuild: Continue with ComputeCssScope
Loading

Assessment against linked issues

Objective Addressed Explanation
Remove all unmatched .razor.css.map files as well as .razor.css files (#11051)

Poem

A rabbit hops through Blazor code,
Sweeping up CSS in cleaning mode.
No stray maps or styles remain,
The build is tidy, free from pain.
With every hop, the files align,
Residuals gone—oh how divine!
🐇✨

✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in a Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props (1)

92-92: Consider forward-slash globs for cross-platform consistency

"**\*.razor.css*" works, but MSBuild treats / and \ differently on some hosts (especially when globbing via bash). Prefer **/*.razor.css* to avoid escaping and remain OS-agnostic.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between eb90698 and 10a3599.

📒 Files selected for processing (1)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build and test
🔇 Additional comments (1)
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props (1)

81-89: Great clarification in XML-doc comments

The expanded comment succinctly explains the orphan-file scenario and why the target must run early. It will save future maintainers time.

@ysmoradi ysmoradi merged commit 24c6a59 into bitfoundation:develop Jul 4, 2025
3 checks passed
@msynk msynk deleted the 11051-templates-boilerplate-msbuild-task-remove-map-files branch July 4, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The .razor.css.map files still remain after moving/removing the corresponding .razor files

2 participants