Improve boilerplate app features (#10963)

[ysmoradi]

closes #10963

Summary by CodeRabbit

• New Features
  • The button for reading user session logs is now only visible to users with the appropriate authorization.
• Refactor
  • Improved the way demo role claims are seeded to reduce repetitive code and ensure unique identifiers.
  • Updated feature identifiers to use a more structured version-like format for better clarity and organization.

[coderabbitai]

Walkthrough

The changes update feature identifier constants in the AppFeatures class to use version-like strings, refactor role claim seeding logic to dynamically generate claims for demo roles, and restrict the display of the user session log button to users with the appropriate authorization policy.

Changes

File(s)	Change Summary
.../Client/Boilerplate.Client.Core/Components/Pages/Authorized/Management/UsersPage.razor	Wrapped the session log button in an AuthorizeView with a policy check for AppFeatures.System.ManageLogs.
.../Server/Boilerplate.Server.Api/Data/Configurations/Identity/RoleClaimConfiguration.cs	Refactored role claim seeding: replaced multiple explicit HasData calls with a loop for demo role claims.
.../Shared/Services/AppFeatures.cs	Updated feature constants to use version-like strings (e.g., "1.0", "2.0") instead of simple numeric strings.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UsersPage
    participant AuthPolicy

    User->>UsersPage: Load Users Page
    UsersPage->>AuthPolicy: Check 'AppFeatures.System.ManageLogs' policy
    alt Authorized
        UsersPage->>User: Show Session Log Button
    else Not Authorized
        UsersPage->>User: Hide Session Log Button
    end

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Update AppFeatures identifiers to structured/version-like strings (#10963)	✅
Refactor role claim seeding to reduce repetition and generalize for demo roles (#10963)	✅
Restrict session log button display to authorized users based on new feature policy (#10963)	✅

Poem

In the warren of code, a version hops by,
Features now numbered like clouds in the sky.
Claims grow in loops, not in tedious rows,
And buttons appear where permission now flows.
With every commit, the garden grows neat—
A rabbit’s delight: improvements complete! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 0d71c66 and b4d3eaa.

📒 Files selected for processing (3)

• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Authorized/Management/UsersPage.razor (1 hunks)
• src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Data/Configurations/Identity/RoleClaimConfiguration.cs (2 hunks)
• src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Services/AppFeatures.cs (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Data/Configurations/Identity/RoleClaimConfiguration.cs (3)

src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Models/Identity/RoleClaim.cs (1)

• RoleClaim (3-6)

src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Services/AppFeatures.cs (3)

• AppFeatures (8-61)
• System (22-33)
• Management (10-20)

src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Services/AppClaimTypes.cs (1)

• AppClaimTypes (7-32)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build and test

🔇 Additional comments (3)

src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Services/AppFeatures.cs (1)

15-15:

✅ Verification successful

LGTM! Improved feature identifier organization.

The migration from simple numeric strings to version-like identifiers (e.g., "1.0", "1.1") provides better organization and allows for future hierarchical expansion. The uniqueness requirement is maintained across all features.

Please verify that all references to these feature constants across the codebase have been updated to use the new values:

Also applies to: 17-17, 19-19, 27-27, 32-32, 37-37, 42-42, 47-47

---

🏁 Script executed:

#!/bin/bash
# Description: Verify that no old feature identifiers remain in the codebase
# Expected: No references to old numeric feature values should be found

echo "Searching for potential old feature identifier patterns..."
rg -n '"[0-9]"' --type cs | grep -v "AppFeatures.cs" | head -20

echo -e "\nSearching for specific old values that might have been missed..."
rg -n '(ClaimValue = ?"[0-9]"|Policy = ?"[0-9]"|Features\.[A-Za-z]+ = ?"[0-9]")' --type cs

Length of output: 3070

---

No remaining old feature identifiers found

The initial grep results only surfaced generic numeric string literals in test utilities and demo components (e.g., BitStackTests.cs, DemoPage.razor.cs), which are unrelated to our feature constants. A focused search for any direct string literals used in feature‐related APIs (claims, policies, feature flags, etc.) returned no hits outside of AppFeatures.cs.

All references to features now correctly use the new version‐style constants in AppFeatures. No further updates are needed here.

src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Authorized/Management/UsersPage.razor (1)

178-184: Excellent security enhancement!

Wrapping the session log download button in AuthorizeView properly restricts access to users with the ManageLogs feature permission. This prevents unauthorized access to potentially sensitive user session logs.

src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Data/Configurations/Identity/RoleClaimConfiguration.cs (1)

12-12: Good approach for unique ID generation.

The incremental ID assignment ensures unique identifiers for all seeded claims while maintaining simplicity.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Copilot]

Pull Request Overview

This pull request improves the identification and uniqueness of app features by updating version strings and refactoring role claim seeding. Key changes include updated version strings in the AppFeatures service, refactored seeding of role claims using an auto-incremented id, and wrapping log management actions with an authorization check in the UsersPage view.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Services/AppFeatures.cs	Updated version values to enforce feature uniqueness.
src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Data/Configurations/Identity/RoleClaimConfiguration.cs	Refactored role claim data seeding by introducing an auto-incremented id and iterating over feature values.
src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Authorized/Management/UsersPage.razor	Added an authorization check for managing user session logs.